Andreas Tolfsen ❲:ato❳ Assignee
	Description • 7 years ago

If interaction.flushEventLoop from testing/marionette/interaction.js is called on a window, that has become or at some point during the operation will become, discared, it will hang.

	Andreas Tolfsen ❲:ato❳ Assignee
	Comment 2 • 7 years ago

Unfortunately this change does not come with any tests as the code path is only hit when the WebDriver conforming Element Click implementation is enabled, but I think the change is sane to the reader.  This change is in preparation of https://bugzilla.mozilla.org/show_bug.cgi?id=1321516.

	Maja Frydrychowicz :impossibus (was :maja_zf) (needinfo me)
	Comment 3 • 7 years ago
mozreview-review

Comment on attachment 8860964 [details]
Bug 1359053 - Reject interaction.flushEventLoop if window is discarded;

https://reviewboard.mozilla.org/r/132974/#review136266

FYI, since the green Wd job is actually busted (I think due to a backout that James has in his backlog), I checked your change locally with an older non-busted harness revision just for sanity to see whether it does anything funky with actions tests. All is well.

	Pulsebot
	Comment 4 • 7 years ago

Pushed by atolfsen@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/325df3ebf1a6
Reject interaction.flushEventLoop if window is discarded; r=maja_zf

	Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)
	Comment 5 • 7 years ago
bugherder

https://hg.mozilla.org/mozilla-central/rev/325df3ebf1a6

	Henrik Skupin [:whimboo][⌚️UTC+1]
	Comment 6 • 7 years ago

Andreas, this patch will cause merge issues for my click+pageload patch to uplift to beta. I think that beside that it would even fix a hang in case frames get closed, so it might be a good candidate to uplift any way, or?

	Andreas Tolfsen ❲:ato❳ Assignee
	Comment 7 • 7 years ago

(In reply to Henrik Skupin (:whimboo) from comment #6)
> Andreas, this patch will cause merge issues for my click+pageload patch to
> uplift to beta. I think that beside that it would even fix a hang in case
> frames get closed, so it might be a good candidate to uplift any way, or?

Seems reasonable to me to uplift this, and I estimate the risk of uplifting
this as minimal.

Sheriffs: Please uplift this to beta as test-only.

	Ryan VanderMeulen [:RyanVM]
	Comment 8 • 7 years ago
bugherder uplift

https://hg.mozilla.org/releases/mozilla-beta/rev/cff5c81e36de