Closed
Bug 1357590
Opened 7 years ago
Closed 7 years ago
Test drag and drop with mouse actions
Categories
(Remote Protocol :: Marionette, enhancement)
Tracking
(firefox55 fixed)
RESOLVED
FIXED
mozilla55
Tracking | Status | |
---|---|---|
firefox55 | --- | fixed |
People
(Reporter: impossibus, Assigned: impossibus)
References
(Blocks 1 open bug)
Details
Attachments
(2 files)
Add wdspec test for drag and drop with pointer actions, pointerType "mouse".
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment 3•7 years ago
|
||
mozreview-review |
Comment on attachment 8859391 [details] Bug 1357590 - Add default button to pointer_up and pointer_down; https://reviewboard.mozilla.org/r/131416/#review134022
Attachment #8859391 -
Flags: review?(ato) → review+
Comment 4•7 years ago
|
||
mozreview-review |
Comment on attachment 8859392 [details] Bug 1357590 - Test drag and drop with mouse actions; https://reviewboard.mozilla.org/r/131418/#review134026 ::: testing/web-platform/tests/webdriver/actions/support/test_actions_wdspec.html:95 (Diff revision 1) > allEvents.events.length = 0; > displayMessage(""); > } > > + function drop(moveHandler) { > + return function(e) { Nit: Space before parenthesis, otherwise it looks like you’re calling a function called "function" with argument "e". ::: testing/web-platform/tests/webdriver/actions/support/test_actions_wdspec.html:95 (Diff revision 1) > allEvents.events.length = 0; > displayMessage(""); > } > > + function drop(moveHandler) { > + return function(e) { Variable e is never used. Leave out? ::: testing/web-platform/tests/webdriver/actions/support/test_actions_wdspec.html:104 (Diff revision 1) > + recordPointerEvent(e); > + }; > + } > + > + function move(el, offsetX, offsetY, timeout) { > + return (e) => { e is usually used in try…catch clauses to mean “error”. Maybe rename it ‘ev’ or ‘event’?
Attachment #8859392 -
Flags: review?(ato) → review+
Comment 5•7 years ago
|
||
I forgot to say in the review, that this looks like solid work.
Comment hidden (mozreview-request) |
Assignee | ||
Comment 7•7 years ago
|
||
mozreview-review-reply |
Comment on attachment 8859392 [details] Bug 1357590 - Test drag and drop with mouse actions; https://reviewboard.mozilla.org/r/131418/#review134026 > Variable e is never used. Leave out? It is used, so dropping this issue.
Comment 8•7 years ago
|
||
We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again. hg error in cmd: hg rebase -s 2922c563fec4 -d c6798f51e462: rebasing 390664:2922c563fec4 "Bug 1357590 - Add default button to pointer_up and pointer_down; r=ato" rebasing 390665:043d0479af3f "Bug 1357590 - Test drag and drop with mouse actions; r=ato" (tip) merging testing/web-platform/meta/MANIFEST.json warning: conflicts while merging testing/web-platform/meta/MANIFEST.json! (edit, then use 'hg resolve --mark') unresolved conflicts (see hg resolve, then hg rebase --continue)
Assignee | ||
Comment 9•7 years ago
|
||
(In reply to Andreas Tolfsen ‹:ato› from comment #5) > I forgot to say in the review, that this looks like solid work. Thanks, and thanks for the quick review!
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment 12•7 years ago
|
||
Pushed by mjzffr@gmail.com: https://hg.mozilla.org/integration/autoland/rev/4750ab2b56f2 Add default button to pointer_up and pointer_down; r=ato https://hg.mozilla.org/integration/autoland/rev/8fd376fc9060 Test drag and drop with mouse actions; r=ato
Comment 13•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/4750ab2b56f2 https://hg.mozilla.org/mozilla-central/rev/8fd376fc9060
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox55:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
Comment 14•7 years ago
|
||
Pushed by james@hoppipolla.co.uk: https://hg.mozilla.org/integration/mozilla-inbound/rev/2e1cde1c33e5 Add default button to pointer_up and pointer_down; r=ato
Comment 15•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/2e1cde1c33e5
Updated•1 year ago
|
Product: Testing → Remote Protocol
You need to log in
before you can comment on or make changes to this bug.
Description
•