Will Kahn-Greene [:willkg] ET needinfo? me Assignee
	Description • 7 years ago

Antenna, like the Socorro collector, removes null bytes from keys and values in the raw crash data. It's been doing it for a while, so it might be "safe", but my basic problem with this is that I don't think the collector should be modifying the crash at all.

Seems like it makes more sense for the processor to do a de-nulling pass. Then if we discover bugs or oddities, we can fix them in the processor and re-process the affected crashes. Further, the processor already has a notes field where it can log how it changed the crash and what problems it encountered.

This bug covers looking into moving the de-nulling code. Maybe it's something we wait on thinking about until after we've rewritten the processor.

	Will Kahn-Greene [:willkg] ET needinfo? me Assignee
	Comment 1 • 7 years ago

Switching bugs to the Processor component.

	Will Kahn-Greene [:willkg] ET needinfo? me Assignee
	Comment 2 • 6 years ago

I want to do this because it simplifies Antenna a bit.

Making this a P2.

	Will Kahn-Greene [:willkg] ET needinfo? me Assignee
	Comment 3 • 6 years ago

There are two things that need to be done here:

1. Add a de-nulling transform rule to the processor that takes the raw crash and de-nulls all the things in it.

If we do this now, the processor will save the de-nulled raw crash over the original. I'm not thrilled about that. If I had my druthers, we'd sort out the situation we have now where the processor stomps on raw crash values. It should never touch the raw crash and never save it. So maybe we shouldn't work on this until after we've sorted out the processor stomping on original data.

2. Anyhow, after those code changes land and are pushed to prod, then we can remove the de-nulling step from the collector.