Implement support for implicit values for aria-value* attributes for scrollbar and slider roles
Categories
(Core :: Disability Access APIs, task, P3)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox70 | --- | fixed |
People
(Reporter: jdiggs, Assigned: mislam, Mentored)
References
(Blocks 1 open bug)
Details
(Whiteboard: [lang=c++])
Attachments
(1 file)
In ARIA 1.1, aria-valuemin, aria-valuenow, and aria-valuemax were given default implicit values for scrollbar and slider: * aria-valuemin is 0 * aria-valuemax is 100 * aria-valuenow is half way between aria-valuemin and aria-valuemax 1. Load data:text/html,<div tabindex="0" role="scrollbar" /> 2. Use Accerciser to examine the element 3. Load data:text/html,<div tabindex="0" role="slider" /> 4. Use Accerciser to examine the element Expected result: The accessible value interface would report a minimum of 0, a maximum of 100, and a current value of 50. Actual result: All values are 0. Note: All values are 0 if you use Accerciser's interface viewer. If you instead use its ipython console, the current and maximum values are 0; however, an error is returned when calling Atspi.Value.get_minimum_value(). Because this error does not occur when the steps are performed using WebKitGtk, I don't believe this is an AT-SPI2 bug. https://rawgit.com/w3c/aria/master/aria/aria.html#scrollbar https://rawgit.com/w3c/aria/master/aria/aria.html#slider
|
Reporter | |
Updated•7 years ago
|
|
||
Comment 1•7 years ago
|
||
This is something we should triage and fix but isn't among our most urgent bugs.(Contributions welcome as always!)
|
||
Updated•5 years ago
|
|
|
||
Comment 2•5 years ago
|
||
This will require changes to the MinValue, CurValue and MaxValue methods in Accessible; e.g.
https://searchfox.org/mozilla-central/source/accessible/generic/Accessible.cpp#1408
If the attribute value is NaN (IsNaN()), return the default. For CurValue, this will obviously require some calculation using the min and max values.
Add tests. We already have some aria-value* tests in accessible/tests/mochitests/events/test_valuechange.html, but we don't need to test events for this, so I think it makes sense to add a new test file in accessible/tests/mochitests/value, similar to test_range.html.
|
||
Updated•5 years ago
|
|
||
Comment 3•5 years ago
|
||
Hi! I would like to work on this issue.
I am unable to replicate this issue as the links in 1st comment are broken.
Can I get some help starting out?
|
|
||
Comment 4•5 years ago
|
||
Thanks for your interest in working on this!
The data URLs in comment 0 will work if you enter them into your address bar; e.g. paste this into the address bar and press enter:
data:text/html,<div tabindex="0" role="slider" />
I'm not sure what platform you're testing on. I'm not familiar enough with Accerciser (on Linux) to give solid instructions. The Accessibility Inspector in Firefox exposes the current value, but not minimum or maximum. However, that should be enough to get you started. So, steps to reproduce might be as follows:
- Open this URL:
data:text/html,<div tabindex="0" role="slider" /> - Right click on the document and select Inspect Accessibility Properties.
- In the accessibility tree, select the "slider".
- In the properties tree, examine the "value" property.
- Expected: The value should be "50".
- Actual: The value is "".
|
Assignee | |
Updated•5 years ago
|
|
|
||
Comment 5•5 years ago
|
||
As discussed, in addition to the changes outlined in comment 2, you'll need to modify Accessible::Value (the string value method) to call CurValue instead of fetching aria-valuenow directly:
https://searchfox.org/mozilla-central/rev/597a69c70a5cce6f42f159eb54ad1ef6745f5432/accessible/generic/Accessible.cpp#1371
Otherwise, where aria-valuenow is implicit, it'll just return the empty string because aria-valuenow isn't specified.
Of course, if CurValue returns IsNaN, you shouldn't output that.
You can use the AppendFloat method of the string.
|
|
Assignee | |
Comment 6•5 years ago
|
||
Pushed by jteh@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/7f1703036acf Implement support for implicit values for aria-value* attributes for scrollbar and slider roles, r=Jamie
|
||
Comment 8•5 years ago
|
||
Backed out changeset 7f1703036acf (bug 1357071) for Browser-chrome failures on accessible/tests/browser/e10s/browser_caching_value.js
Log:
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=263984747&repo=autoland&lineNumber=1574
Push with failures:
https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=7f1703036acfcd9e90003a8468fee793500556ae
Backout:
https://hg.mozilla.org/integration/autoland/rev/f6148cf68e11c2c3053d6833071017d993dd626b
Pushed by jteh@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/7af553376576 Implement support for implicit values for aria-value* attributes for scrollbar and slider roles, r=Jamie
|
|
Assignee | |
Updated•5 years ago
|
|
||
Comment 10•5 years ago
|
||
| bugherder | ||
|
||
Comment 11•5 years ago
|
||
| bugherder uplift | ||
Description
•