Brendan Dahl [:bdahl] Assignee
	Description • 7 years ago

Add a --headless flag on Linux that starts the browser in headless mode.

	Bleddle
	Comment 1 • 7 years ago

Hopefully this is the right place, but it would be great to remove the pulse-audio dependency in headless mode. Pulseaudio carries a lot of baggage and getting rid of it on headless would make VM images much smaller.

Thanks for working on this btw.

	Daniele "Mte90" Scasciafratte
	Comment 2 • 7 years ago

Uhm pulseaudio can be useful to show video or audio so I think that is required also on headless, maybe is a topic for another ticket. I am not sure if Firefox can be build without pulseaudio but I think that in that case will be better :-)

Any news for this? Beucase I want to experiment on top of it and on Linux is very important to enable the support also to the embedded/IoT world.

	Daniele "Mte90" Scasciafratte
	Comment 3 • 7 years ago

Actually on Linux I get:

 $  MOZ_HEADLESS=1 /home/mte90/ffnightly/firefox
*** You are running in headless mode.
*** You are running in headless mode.

(firefox:9635): Gdk-CRITICAL **: gdk_x11_display_get_xdisplay: assertion 'GDK_IS_DISPLAY (display)' failed
ExceptionHandler::GenerateDump cloned child 9669
ExceptionHandler::SendContinueSignalToChild sent continue signal to child
ExceptionHandler::WaitForContinueSignal waiting for continue signal...


And this is the report on https://crash-stats.mozilla.com/report/index/bc227383-278d-4e48-a4f4-8f9380170424

	Bleddle
	Comment 4 • 7 years ago

(In reply to Daniele "Mte90" Scasciafratte from comment #2)
> Uhm pulseaudio can be useful to show video or audio so I think that is
> required also on headless, maybe is a topic for another ticket. I am not
> sure if Firefox can be build without pulseaudio but I think that in that
> case will be better :-)

It can be useful, but only if you want to hear something. I'm betting headless will more likely be used for automatic testing where you neither need to hear nor see anything. It would make sense to have a default null fallback that allows calls, but doesn't try to actually access a device. VLC does it and they are all about audio/video.

	Brendan Dahl [:bdahl] Assignee
	Comment 5 • 7 years ago

Adds support for a --headless flag for marionette to start
Firefox in headless mode. Also, adds a new task cluster
test group for the headless marionette tests.

	Brendan Dahl [:bdahl] Assignee
	Comment 6 • 7 years ago

These are various fixes to get most of the headless
marionette tests working.

	Brendan Dahl [:bdahl] Assignee
	Comment 7 • 7 years ago

Supports changing the size of a headless screen with
environment variables.

	Brendan Dahl [:bdahl] Assignee
	Comment 9 • 7 years ago

Alert dialogs trigger a call into gtk to get native sound which
crashes in headless.

	Kan-Ru Chen [:kanru] (UTC+9)
	Comment 10 • 7 years ago

Comment on attachment 8864328 [details] [diff] [review]
Part 3 - Add headless screen helper.

Review of attachment 8864328 [details] [diff] [review]:
-----------------------------------------------------------------

::: widget/headless/HeadlessScreenHelper.cpp
@@ +31,5 @@
> +
> +HeadlessScreenHelper::HeadlessScreenHelper()
> +{
> +  AutoTArray<RefPtr<Screen>, 4> screenList;
> +  LayoutDeviceIntRect rect = GetScreenRect();

The list always only has one element so this should be 1

	David Burns :automatedtester
	Comment 11 • 7 years ago

Comment on attachment 8864326 [details] [diff] [review]
Part 1 - Add headless marionette tests.

Review of attachment 8864326 [details] [diff] [review]:
-----------------------------------------------------------------

This looks good. It might be worth speaking to the TC team to make sure they are aware of the increase in load.

	Jeff Muizelaar [:jrmuizel]
	Comment 12 • 7 years ago

Comment on attachment 8864329 [details] [diff] [review]
Part 4 - Support moving a headless window.

Review of attachment 8864329 [details] [diff] [review]:
-----------------------------------------------------------------

::: widget/headless/HeadlessWidget.cpp
@@ +86,5 @@
> +      mWindowType == eWindowType_dialog) {
> +      SetSizeMode(nsSizeMode_Normal);
> +  }
> +
> +  // Since a popup window's x/y coordinates are in relation to to

to to

	Brendan Dahl [:bdahl] Assignee
	Comment 13 • 7 years ago

Some new marionette tests for windows size changes were added while I was on PTO.

	Brendan Dahl [:bdahl] Assignee
	Comment 14 • 7 years ago

Hopefully the last part for this bug.

	Jeff Muizelaar [:jrmuizel]
	Comment 15 • 7 years ago

Comment on attachment 8867943 [details] [diff] [review]
Part 7 - Add the --headless flag.

Review of attachment 8867943 [details] [diff] [review]:
-----------------------------------------------------------------

::: toolkit/xre/nsAppRunner.cpp
@@ +3147,5 @@
>    }
>  
> +  if (CheckArg("headless")) {
> +    PR_SetEnv("MOZ_HEADLESS=1");
> +  }

We should switch using a bool or something like gfxConfig instead of the environment variable directly. i.e. gfxPlatform::IsHeadless() shouldn't be checking the environment variables.

	Brendan Dahl [:bdahl] Assignee
	Comment 16 • 7 years ago

As discussed on IRC, IsHeadless is needed pretty early on startup before gfxConfig is initialized. We could add a gfxPlatform::EnableHeadless, but this would require each new process to call this. Just using an environment variable and caching it seems the simplest for now.

	Pulsebot
	Comment 17 • 7 years ago

Pushed by bdahl@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/d7121e5ad806
Expand headless mode support for linux. r=automatedtester,jrmuizel,kanru

	Ryan VanderMeulen [:RyanVM]
	Comment 18 • 7 years ago
bugherder

https://hg.mozilla.org/mozilla-central/rev/d7121e5ad806