James Graham [:jgraham] Reporter
	Description • 7 years ago

Needed for CSS at the moment.

	Andreas Tolfsen ❲:ato❳
	Comment 2 • 7 years ago
mozreview-review

Comment on attachment 8857924 [details]
Bug 1356227 - Add support for excluding paths when doing a wpt sync,

https://reviewboard.mozilla.org/r/129958/#review132532

::: testing/web-platform/harness/wptrunner/update/tree.py:319
(Diff revision 1)
> -            rel_path = os.path.relpath(repo_path, self.root)
> -            rv.extend(os.path.join(rel_path, item.strip()) for item in paths if item.strip())
> +            rv.extend(os.path.relpath(os.path.join(repo_path, item), self.root) for item in paths
> +                      if item.strip())

This is OK, but it is closing in on the complexity that would justify splitting it up as a normal iterator in my opinion.

It took me a while to understand what item.strip() meant because it basically just relies on the falsiness of it.

	Pulsebot
	Comment 3 • 7 years ago

Pushed by james@hoppipolla.co.uk:
https://hg.mozilla.org/integration/mozilla-inbound/rev/c9919c878c14
Add support for excluding paths when doing a wpt sync, r=ato

	Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)
	Comment 4 • 7 years ago
bugherder

https://hg.mozilla.org/mozilla-central/rev/c9919c878c14

	Pulsebot
	Comment 5 • 7 years ago

Backout by archaeopteryx@coole-files.de:
https://hg.mozilla.org/mozilla-central/rev/1a1069b27f40
Backed out changeset c9919c878c14 for neverending W(7) jobs on Windows 7 VM debug. r=backout a=backout

	Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)
	Comment 6 • 7 years ago
backout bugherder

Backed out for neverending W(7) jobs on Windows 7 VM debug:
https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=f98b750bb85085a61341dc267f5ebf313820f960&filter-searchStr=2e76e93115e24a1caffbba81d961e84fb651fa8c
https://hg.mozilla.org/mozilla-central/rev/1a1069b27f40

	Pulsebot
	Comment 7 • 7 years ago

Pushed by james@hoppipolla.co.uk:
https://hg.mozilla.org/integration/mozilla-inbound/rev/f7b360ab2445
Add support for excluding paths when doing a wpt sync, r=ato

	Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)
	Comment 8 • 7 years ago
bugherder

https://hg.mozilla.org/mozilla-central/rev/f7b360ab2445