Closed Bug 1355460 Opened 7 years ago Closed 2 years ago

Speculatively connect to bookmarked sites on mousedown

Categories

(Firefox :: Bookmarks & History, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
98 Branch
Tracking Status
firefox98 --- fixed

People

(Reporter: florian, Assigned: janey)

References

(Blocks 2 open bugs)

Details

(Whiteboard: [fxsearch] [fxperf:p3])

Attachments

(1 file)

When the user presses the left mouse button on a bookmark item (either from the bookmark menu or from the bookmark toolbar), or on a history item, we have a strong signal that the user is about to load that page, so we should speculatively connect to the server.
Flags: qe-verify+
Priority: -- → P2
QA Contact: adrian.florinescu
Whiteboard: [photon][fxsearch] → [photon-performance] [fxsearch]
Priority: P2 → P3
Whiteboard: [photon-performance] [fxsearch] → [reserve-photon-performance] [fxsearch]
Priority: P3 → P4
Priority: P4 → P3
Whiteboard: [reserve-photon-performance] [fxsearch] → [reserve-photon-performance] [fxsearch] [fxperf]
Whiteboard: [reserve-photon-performance] [fxsearch] [fxperf] → [fxsearch] [fxperf:p3]

This should be behind a pref, a boolean browser.places.speculativeConnect.enabled would probably be fine, since it mirrors the browser.urlbar. one.
For testing, I assume here we'll add an helper method to PlacesUIUtils, the test can then use the Sinon library to replace the method with a Spy, and just check it's invoked.
We'd also support this only for views that allow a single selection, so menus and toolbars. The trees are often used to manage and move bookmarks around with D&D, and we don't want those actions to begin connections.

This is an example of how the Urlbar implements it: https://searchfox.org/mozilla-central/rev/dc323d0d9a3b722ca8ff0d1b2b752e5bd00dab9b/browser/components/urlbar/UrlbarUtils.jsm#728-730,753-757

Assignee: nobody → jenyakotovich
Status: NEW → ASSIGNED
Attachment #9256698 - Attachment description: Bug 1355460 - Speculatively connect toolbar & menu to bookmaarked site on mousedown. r?mak → Bug 1355460 - Speculatively connect toolbar & menu to bookmarked site on mousedown. r?mak
Attachment #9256698 - Attachment description: Bug 1355460 - Speculatively connect toolbar & menu to bookmarked site on mousedown. r?mak → Bug 1355460 - Speculatively connect toolbar & menu to bookmarked site on mousedown. r?mak,standard8
Attachment #9256698 - Attachment description: Bug 1355460 - Speculatively connect toolbar & menu to bookmarked site on mousedown. r?mak,standard8 → Bug 1355460 - Speculatively connect toolbar & menu to bookmarked site on mousedown. r?mak
Pushed by mak77@bonardo.net:
https://hg.mozilla.org/integration/autoland/rev/f9ab66e133a3
Speculatively connect toolbar & menu to bookmarked site on mousedown. r=mak
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 98 Branch

Hello, would manual QA testing be needed for this issue? If yes, could you please provide the steps needed to properly verify this? Thank you.

Flags: needinfo?(mak)

(In reply to Ardelean Oana from comment #5)

Hello, would manual QA testing be needed for this issue? If yes, could you please provide the steps needed to properly verify this? Thank you.

I don't think we need manual QA, we have an automated test, it's a minor perf improvement that doesn't ideally show anything different to the user.

Flags: needinfo?(mak) → needinfo?(oana.ardelean)
Flags: needinfo?(oana.ardelean)
Regressions: 1841429
Blocks: 1841429
No longer regressions: 1841429
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: