Treeherder Bug Filer Reporter
	Description • 7 years ago
treeherder

Filed by: wkocher [at] mozilla.com

https://treeherder.mozilla.org/logviewer.html#?job_id=89240177&repo=autoland

https://archive.mozilla.org/pub/firefox/tinderbox-builds/autoland-win64-debug/1491495212/autoland_win8_64-debug_test-marionette-e10s-bm119-tests1-windows-build401.txt.gz

	Henrik Skupin [:whimboo][⌚️UTC+1] Assignee
	Comment 1 • 7 years ago

This is a debug build and having a timeout of 5s for a page to be loaded seems wrong. Instead it should use `self.marionette.timeout.page_load`.

>        Wait(self.marionette).until(
>            lambda mn: mn.get_url() == self.test_page_remote,
>            message="'{}' hasn't been loaded".format(self.test_page_remote))

The same applies to the test `test_type_to_non_remote_tab`, and maybe others.

	Andreas Tolfsen ❲:ato❳
	Comment 4 • 7 years ago
mozreview-review

Comment on attachment 8855673 [details]
Bug 1354310 - Ensure to use page load timeout for Wait().until() in unit tests.

https://reviewboard.mozilla.org/r/127538/#review130352

	Pulsebot
	Comment 5 • 7 years ago

Pushed by hskupin@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/ef76a3b0eb7d
Ensure to use page load timeout for Wait().until() in unit tests. r=ato

	Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)
	Comment 6 • 7 years ago
bugherder

https://hg.mozilla.org/mozilla-central/rev/ef76a3b0eb7d

	Henrik Skupin [:whimboo][⌚️UTC+1] Assignee
	Comment 7 • 7 years ago

Please uplift this test-only patch to aurora and beta. Thank you.

	Carsten Book [:Tomcat]
	Comment 8 • 7 years ago
bugherder uplift

https://hg.mozilla.org/releases/mozilla-aurora/rev/0d8df2fe95cc

	Carsten Book [:Tomcat]
	Comment 9 • 7 years ago
bugherder uplift

https://hg.mozilla.org/releases/mozilla-beta/rev/0fe6857edaff

	Ryan VanderMeulen [:RyanVM]
	Comment 10 • 7 years ago

This'll need rebasing if you want to uplift to esr52.

	Henrik Skupin [:whimboo][⌚️UTC+1] Assignee
	Comment 11 • 7 years ago

If it would be a (near) perma-fail a backport patch would make sense. But as of now it doesn't warrant the work. So I will mark esr52 as wontfix. We can re-evaluate if it becomes a problem in the future.

	BMO Automation
	Comment 14 • 1 year ago

Moving bug to Testing::Marionette Client and Harness component per bug 1815831.