Closed
Bug 1350646
Opened 7 years ago
Closed 7 years ago
Remove UI, extension, and child_process modules
Categories
(Add-on SDK Graveyard :: General, enhancement)
Add-on SDK Graveyard
General
Tracking
(Performance Impact:high, firefox57 fixed)
| Tracking | Status | |
|---|---|---|
| firefox57 | --- | fixed |
People
(Reporter: kmag, Assigned: kmag)
References
(Blocks 1 open bug)
Details
Attachments
(22 files)
|
59 bytes,
text/x-review-board-request
|
mossop
:
review+
|
Details |
|
59 bytes,
text/x-review-board-request
|
mossop
:
review+
|
Details |
|
59 bytes,
text/x-review-board-request
|
mossop
:
review+
|
Details |
|
59 bytes,
text/x-review-board-request
|
mossop
:
review+
|
Details |
|
59 bytes,
text/x-review-board-request
|
mossop
:
review+
|
Details |
|
59 bytes,
text/x-review-board-request
|
mossop
:
review+
|
Details |
|
59 bytes,
text/x-review-board-request
|
mossop
:
review+
|
Details |
|
59 bytes,
text/x-review-board-request
|
mossop
:
review+
|
Details |
|
59 bytes,
text/x-review-board-request
|
mossop
:
review+
|
Details |
|
59 bytes,
text/x-review-board-request
|
mossop
:
review+
|
Details |
|
59 bytes,
text/x-review-board-request
|
mossop
:
review+
|
Details |
|
59 bytes,
text/x-review-board-request
|
mossop
:
review+
|
Details |
|
59 bytes,
text/x-review-board-request
|
mossop
:
review+
|
Details |
|
59 bytes,
text/x-review-board-request
|
mossop
:
review+
|
Details |
|
59 bytes,
text/x-review-board-request
|
mossop
:
review+
|
Details |
|
59 bytes,
text/x-review-board-request
|
mossop
:
review+
|
Details |
|
59 bytes,
text/x-review-board-request
|
mossop
:
review+
|
Details |
|
59 bytes,
text/x-review-board-request
|
mossop
:
review+
|
Details |
|
59 bytes,
text/x-review-board-request
|
mossop
:
review+
|
Details |
|
59 bytes,
text/x-review-board-request
|
mossop
:
review+
|
Details |
|
59 bytes,
text/x-review-board-request
|
mossop
:
review+
|
Details |
|
59 bytes,
text/x-review-board-request
|
mossop
:
review+
|
Details |
The UI and extension modules are among the most performance sucks in the SDK at the moment. They should be our first priority for removal after legacy add-on support is removed. This is the draft list of modules I intend to start with: ./addon/bootstrap.js ./addon/events.js ./addon/host.js ./addon/installer.js ./addon/manager.js ./addon/runner.js ./addon/window.js ./browser/events.js ./context-menu.js ./context-menu/context.js ./context-menu/core.js ./context-menu/readers.js ./context-menu@2.js ./dom/events-shimmed.js ./dom/events.js ./dom/events/keys.js ./frame/hidden-frame.js ./frame/utils.js ./hotkeys.js ./input/browser.js ./input/customizable-ui.js ./input/frame.js ./input/system.js ./keyboard/hotkeys.js ./keyboard/observer.js ./keyboard/utils.js ./model/core.js ./notifications.js ./page-mod.js ./page-mod/match-pattern.js ./page-worker.js ./panel.js ./panel/events.js ./panel/utils.js ./private-browsing.js ./private-browsing/utils.js ./self.js ./simple-prefs.js ./simple-storage.js ./system/child_process.js ./system/child_process/subprocess.js ./tab/events.js ./tabs.js ./tabs/common.js ./tabs/events.js ./tabs/helpers.js ./tabs/namespace.js ./tabs/observer.js ./tabs/tab-fennec.js ./tabs/tab-firefox.js ./tabs/tab.js ./tabs/tabs-firefox.js ./tabs/utils.js ./tabs/worker.js ./ui.js ./ui/button/action.js ./ui/button/contract.js ./ui/button/toggle.js ./ui/button/view.js ./ui/button/view/events.js ./ui/component.js ./ui/frame.js ./ui/frame/model.js ./ui/frame/view.js ./ui/id.js ./ui/sidebar.js ./ui/sidebar/actions.js ./ui/sidebar/contract.js ./ui/sidebar/namespace.js ./ui/sidebar/utils.js ./ui/sidebar/view.js ./ui/state.js ./ui/state/events.js ./ui/toolbar.js ./ui/toolbar/model.js ./ui/toolbar/view.js ./view/core.js ./webextension.js ./window/browser.js ./window/events.js ./window/helpers.js ./window/namespace.js ./windows.js ./windows/fennec.js ./windows/firefox.js ./windows/observer.js ./windows/tabs-fennec.js
|
||
Comment 1•7 years ago
|
||
Can we remove locale.js please? We have a fully functional moziLocaleService which should be used instead
|
Assignee | |
Comment 2•7 years ago
|
||
It's definitely in for the offing, but it's not one of my highest priorities.
|
||
Updated•7 years ago
|
Blocks: QuantumFlow
|
||
Updated•7 years ago
|
Whiteboard: [qf]
|
|
||
Updated•7 years ago
|
Whiteboard: [qf] → [qf:p1]
The plan is to migrate devtools off these modules, which won't happen until 57.
|
||
Comment 4•7 years ago
|
||
(In reply to Anthony Jones (:kentuckyfriedtakahe, :k17e) from comment #3) > The plan is to migrate devtools off these modules, which won't happen until > 57. Could you please give more details? What do you mean by "won't happen until 57"? Can we at least ensure that none of these modules are used by the devtools code that runs before the user has interacted with devtools in the session?
Flags: needinfo?(ajones)
|
|
Assignee | |
Comment 5•7 years ago
|
||
Hopefully devtools should migrate off these modules well before 57, but we can't remove them until we stop supporting SDK add-ons, which won't be until 57.
Flags: needinfo?(ajones)
|
|
||
Comment 6•7 years ago
|
||
Do we need to somehow ensure that devtools actually migrates away? I'm worried about the "hopefully" part in comment 5. :-)
|
|
Assignee | |
Comment 7•7 years ago
|
||
Well, I say "hopefully" because I have no control over or real involvement in what the devtools team does, so it's the best I can say. Perhaps someone from that team can say something more definite.
Flags: needinfo?(jryans)
(In reply to Kris Maglione [:kmag] from comment #7) > Well, I say "hopefully" because I have no control over or real involvement > in what the devtools team does, so it's the best I can say. Perhaps someone > from that team can say something more definite. We've got bug 1350645 tracking the clean up in DevTools. I have moved over to the Stylo effort, so I'm no longer working full time on DevTools. :pbro, can DevTools assign an owner for this effort to drive it to completion?
Flags: needinfo?(jryans) → needinfo?(pbrosset)
|
||
Comment 9•7 years ago
|
||
Can we clarify that if we have zero SDK add-ons on 57 release, this ceases to be a concern for quantum flow?
|
|
||
Comment 10•7 years ago
|
||
(In reply to Kris Maglione [:kmag] from comment #7) > Well, I say "hopefully" because I have no control over or real involvement > in what the devtools team does, so it's the best I can say. Perhaps someone > from that team can say something more definite. Yeah sorry my comment wasn't directed at you, my apologies if this came off the wrong way. I just want to ensure the work is prioritized correctly and the devtools team is aware of it. :-) Let's wait to hear from Patrick...
|
||
Comment 11•7 years ago
|
||
(In reply to J. Ryan Stinnett [:jryans] (use ni?) from comment #8) > We've got bug 1350645 tracking the clean up in DevTools. I have moved over > to the Stylo effort, so I'm no longer working full time on DevTools. > > :pbro, can DevTools assign an owner for this effort to drive it to > completion? Bug 1350645 should now be up to date with respect to blockers. I've filed all the remaining blocker bugs based on this comment from Kris: bug 1350645 comment 2. A bunch of bugs have already been fixed, and 7 remain. As of today, we do not have anyone in DevTools assigned to work on this full time. So this is being worked on rather slowly, as a side thing to people's quarterly goals, but we do have it on our radar and are making progress. My plan so far is: I'll make sure there's at least some momentum on this until the end of Q2 (i.e. a few more bugs get fixed). And then assign someone to work on this full time at the beginning of Q3 (which means before the 57 nightly cycle starts). Looking at the remaining list of blockers in bug 1350645, I think this should work. Only bug 952653 seems big, the rest looks simple. Again, this is based on the high priority list given by Kris in bug 1350645 comment 2. If this list changes or if we need something sooner than this, let me know, we can always change priorities (of course, at the cost of something else no being done in Q2).
Flags: needinfo?(pbrosset)
|
||
Updated•7 years ago
|
Blocks: post-57-api-changes
No longer depends on: post-57-api-changes
|
||
Comment 12•7 years ago
|
||
(In reply to Patrick Brosset <:pbro> from comment #11) > (In reply to J. Ryan Stinnett [:jryans] (use ni?) from comment #8) > > We've got bug 1350645 tracking the clean up in DevTools. I have moved over > > to the Stylo effort, so I'm no longer working full time on DevTools. > > > > :pbro, can DevTools assign an owner for this effort to drive it to > > completion? > Bug 1350645 should now be up to date with respect to blockers. I've filed > all the remaining blocker bugs based on this comment from Kris: bug 1350645 > comment 2. > > A bunch of bugs have already been fixed, and 7 remain. > As of today, we do not have anyone in DevTools assigned to work on this full > time. So this is being worked on rather slowly, as a side thing to people's > quarterly goals, but we do have it on our radar and are making progress. > > My plan so far is: I'll make sure there's at least some momentum on this > until the end of Q2 (i.e. a few more bugs get fixed). And then assign > someone to work on this full time at the beginning of Q3 (which means before > the 57 nightly cycle starts). Was that able to happen? I see lots of bugs being added/removed from the tracker :)
Flags: needinfo?(pbrosset)
|
|
||
Comment 13•7 years ago
|
||
(In reply to Andrew Overholt [:overholt] from comment #12) > Was that able to happen? I see lots of bugs being added/removed from the > tracker :) Yes. We have kicked off a project in Q3 aiming at removing all of our SDK dependencies in DevTools. 2 of the big ones we have are Heritage and Event, which we are working on first. The team has been creating many bugs to track the work. All of which should be in the dependency tree of bug 1350645.
Flags: needinfo?(pbrosset)
|
||
Comment 14•7 years ago
|
||
From /devtools, it looks like we are "only" depending on these modules: - clipboard - core/heritage - event/core - event/target - indexed-db - lang/functional/concurrent.js - system/child_process/subprocess - system/environment - system/events - system/runtime - timers - util/object - util/uuid In this list, only subprocess is referenced in comment 0. This is tracked by bug 1378832, should we only/mostly focus on that? Or is the bug about removing all the SDK? Then we should rename it. What is the target here? Should we aim for: * in two weeks as 57 cycle begins? * before 57 goes to beta? * in mid-cycle of 57? Is DevTools the only blocker here? If yes, once we are on 57, should be remove SDK modules one by one as we start removing dependencies on them?
|
||
Comment 15•7 years ago
|
||
We have a bug to remove all dependencies from SDK from devtools (bug 1350645), but *when* are you planning to remove the SDK from the code base exactly? This will help us prioritise. I've been reading these comments and the comments elsewhere (omg there are so many bugs opened for this) and none points exactly to a fixed date. Is it "after 57 is released" meaning sometime in the 58 cycle or...? etc thanks!
Flags: needinfo?(kmaglione+bmo)
|
|
Assignee | |
Comment 16•7 years ago
|
||
I'm planning to disable most of the SDK tests as soon as 56 merges to beta. I'm hoping to stop shipping most SDK modules by the end of the 57 cycle
Flags: needinfo?(kmaglione+bmo)
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
|
||
Comment 39•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8894163 [details] Bug 1350646: Part 1 - Remove addon-sdk moz.build generation gunk. https://reviewboard.mozilla.org/r/165242/#review171376
Attachment #8894163 -
Flags: review?(dtownsend) → review+
|
|
||
Comment 40•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8894164 [details] Bug 1350646: Part 2 - Sort SDK module sources list. https://reviewboard.mozilla.org/r/165244/#review171380
Attachment #8894164 -
Flags: review?(dtownsend) → review+
|
|
||
Comment 41•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8894165 [details] Bug 1350646: Part 3 - Remove sdk/system/child_process modules. https://reviewboard.mozilla.org/r/165246/#review171382
Attachment #8894165 -
Flags: review?(dtownsend) → review+
|
|
||
Comment 42•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8894166 [details] Bug 1350646: Part 4 - Remove most modules which depend on sdk/addon/*. https://reviewboard.mozilla.org/r/165248/#review171386
Attachment #8894166 -
Flags: review?(dtownsend) → review+
|
|
||
Comment 43•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8894167 [details] Bug 1350646: Part 5 - Remove sdk/addon/* modules. https://reviewboard.mozilla.org/r/165250/#review171388
Attachment #8894167 -
Flags: review?(dtownsend) → review+
|
|
||
Comment 44•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8894168 [details] Bug 1350646: Part 6 - Remove SDK UI modules. https://reviewboard.mozilla.org/r/165252/#review171390
Attachment #8894168 -
Flags: review?(dtownsend) → review+
|
|
||
Comment 45•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8894169 [details] Bug 1350646: Part 7 - Remove SDK hotkey modules. https://reviewboard.mozilla.org/r/165254/#review171394
Attachment #8894169 -
Flags: review?(dtownsend) → review+
|
|
||
Comment 46•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8894170 [details] Bug 1350646: Part 8 - Remove SDK page-mod modules. https://reviewboard.mozilla.org/r/165256/#review171396
Attachment #8894170 -
Flags: review?(dtownsend) → review+
|
|
||
Comment 47•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8894171 [details] Bug 1350646: Part 9 - Remove SDK l10n modules. https://reviewboard.mozilla.org/r/165258/#review171398
Attachment #8894171 -
Flags: review?(dtownsend) → review+
|
|
||
Comment 48•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8894172 [details] Bug 1350646: Part 10 - Remove SDK tabs/windows modules. https://reviewboard.mozilla.org/r/165260/#review171400
Attachment #8894172 -
Flags: review?(dtownsend) → review+
|
|
||
Comment 49•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8894173 [details] Bug 1350646: Part 11 - Remove SDK stylesheet modules. https://reviewboard.mozilla.org/r/165262/#review171404
Attachment #8894173 -
Flags: review?(dtownsend) → review+
|
|
||
Comment 50•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8894174 [details] Bug 1350646: Part 12 - Remove SDK simple-prefs module. https://reviewboard.mozilla.org/r/165264/#review171406
Attachment #8894174 -
Flags: review?(dtownsend) → review+
|
|
||
Comment 51•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8894175 [details] Bug 1350646: Part 13 - Remove most SDK io modules. https://reviewboard.mozilla.org/r/165266/#review171408
Attachment #8894175 -
Flags: review?(dtownsend) → review+
|
|
||
Comment 52•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8894176 [details] Bug 1350646: Part 13 - Remove several SDK test modules. https://reviewboard.mozilla.org/r/165268/#review171410
Attachment #8894176 -
Flags: review?(dtownsend) → review+
|
|
||
Comment 53•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8894177 [details] Bug 1350646: Part 14 - Remove SDK net/request modules. https://reviewboard.mozilla.org/r/165270/#review171412
Attachment #8894177 -
Flags: review?(dtownsend) → review+
|
|
||
Comment 54•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8894178 [details] Bug 1350646: Part 15 - Remove SDK storage modules. https://reviewboard.mozilla.org/r/165272/#review171414 Files not actually deleted it seem.
Attachment #8894178 -
Flags: review?(dtownsend) → review+
|
|
||
Comment 55•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8894179 [details] Bug 1350646: Part 16 - Remove SDK notifications module. https://reviewboard.mozilla.org/r/165274/#review171416
Attachment #8894179 -
Flags: review?(dtownsend) → review+
|
|
||
Comment 56•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8894180 [details] Bug 1350646: Part 17 - Remove SDK DOM events modules. https://reviewboard.mozilla.org/r/165276/#review171418
Attachment #8894180 -
Flags: review?(dtownsend) → review+
|
|
||
Comment 57•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8894180 [details] Bug 1350646: Part 17 - Remove SDK DOM events modules. https://reviewboard.mozilla.org/r/165276/#review171420
|
|
||
Comment 58•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8894181 [details] Bug 1350646: Part 18 - Remove SDK MVC modules. https://reviewboard.mozilla.org/r/165278/#review171422
Attachment #8894181 -
Flags: review?(dtownsend) → review+
|
|
||
Comment 59•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8894182 [details] Bug 1350646: Part 19 - Remove SDK passwords modules. https://reviewboard.mozilla.org/r/165280/#review171424
Attachment #8894182 -
Flags: review?(dtownsend) → review+
|
|
||
Comment 60•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8894183 [details] Bug 1350646: Part 20 - Remove remaining SDK content modules. https://reviewboard.mozilla.org/r/165282/#review171426
Attachment #8894183 -
Flags: review?(dtownsend) → review+
|
|
||
Comment 61•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8894184 [details] Bug 1350646: Part 21 - Remove SDK api-utils and dependent modules. https://reviewboard.mozilla.org/r/165284/#review171428
Attachment #8894184 -
Flags: review?(dtownsend) → review+
|
||
Comment 62•7 years ago
|
||
Just for clarification, when discussed, we had agreed no SDK removal until at least 58/59. Support for loading SDK addons goes away in 57, but removal shouldn't be targeted before 58. Correct?
|
|
Assignee | |
Comment 63•7 years ago
|
||
(In reply to Kev Needham [:kev] from comment #62) > Just for clarification, when discussed, we had agreed no SDK removal until > at least 58/59. Support for loading SDK addons goes away in 57, but removal > shouldn't be targeted before 58. Correct? The plan has been to remove most of the SDK in 57 for the last couple of months. We initially planned to push it back for the sake of Android, but since then we've come to the agreement that Android WebExtension support is good enough that that's not necessary.
|
|
||
Comment 64•7 years ago
|
||
kk. we should remind test/release as well, jic there are any lingering SDK extensions that need migrating. thankees.
|
|
Assignee | |
Comment 65•7 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/67c251e2c9db1d42a8de6d09a44e9e2f7be084a4 Bug 1350646: Part 1 - Remove addon-sdk moz.build generation gunk. r=Mossop https://hg.mozilla.org/integration/mozilla-inbound/rev/8d4c2f001354b186da9e411d2ff1def458d00efc Bug 1350646: Part 2 - Sort SDK module sources list. r=Mossop https://hg.mozilla.org/integration/mozilla-inbound/rev/3ca040743aebaa3f0c971fcd8de3fe798121bcd8 Bug 1350646: Part 3 - Remove sdk/system/child_process modules. r=Mossop https://hg.mozilla.org/integration/mozilla-inbound/rev/c68367bb0eb39090b8bb1925916dea24bdbfe6b0 Bug 1350646: Part 4 - Remove most modules which depend on sdk/addon/*. r=Mossop https://hg.mozilla.org/integration/mozilla-inbound/rev/7687db57501117fc79102f78cdefecaa7d16c8e0 Bug 1350646: Part 5 - Remove sdk/addon/* modules. r=Mossop https://hg.mozilla.org/integration/mozilla-inbound/rev/35c4d4cd77c7d33aa1ba0fd93f0e369d3a452232 Bug 1350646: Part 6 - Remove SDK UI modules. r=Mossop https://hg.mozilla.org/integration/mozilla-inbound/rev/d914c050c9650fb677f6868abf62a84c56e81849 Bug 1350646: Part 7 - Remove SDK hotkey modules. r=Mossop https://hg.mozilla.org/integration/mozilla-inbound/rev/e931e4ff5e11823a5154023deb6b4fbb70379fb7 Bug 1350646: Part 8 - Remove SDK page-mod modules. r=Mossop https://hg.mozilla.org/integration/mozilla-inbound/rev/5a45d9e25a007c6ab18bd8da4a41f0fe3b9318c0 Bug 1350646: Part 9 - Remove SDK l10n modules. r=Mossop https://hg.mozilla.org/integration/mozilla-inbound/rev/57500d9ea8321c962ec6748082b1a084c928550f Bug 1350646: Part 10 - Remove SDK tabs/windows modules. r=Mossop https://hg.mozilla.org/integration/mozilla-inbound/rev/096ff315b48b51aae1863b687fff74707e8e04c3 Bug 1350646: Part 11 - Remove SDK stylesheet modules. r=Mossop https://hg.mozilla.org/integration/mozilla-inbound/rev/13110c98b0fd79643e204b07a75476b889e0ff81 Bug 1350646: Part 12 - Remove SDK simple-prefs module. r=Mossop https://hg.mozilla.org/integration/mozilla-inbound/rev/6d9244a8ac40c7daffc95917a4c7a58652d859d9 Bug 1350646: Part 13 - Remove most SDK io modules. r=Mossop https://hg.mozilla.org/integration/mozilla-inbound/rev/5eb77e6de0a363b04077ef2d2e6c3384c3cae644 Bug 1350646: Part 13 - Remove several SDK test modules. r=Mossop https://hg.mozilla.org/integration/mozilla-inbound/rev/e40544ead983c302f276eca192457553d99ed0de Bug 1350646: Part 14 - Remove SDK net/request modules. r=Mossop https://hg.mozilla.org/integration/mozilla-inbound/rev/10bbf7c53afeab1bf8e55e39cd97ed9feeed63f4 Bug 1350646: Part 15 - Remove SDK storage modules. r=Mossop https://hg.mozilla.org/integration/mozilla-inbound/rev/7f65323c56f9ebf89ac6b30e03b083802e48eff4 Bug 1350646: Part 16 - Remove SDK notifications module. r=Mossop https://hg.mozilla.org/integration/mozilla-inbound/rev/7571b064a77e55a604d1dfefd86a6b1a57ea5c11 Bug 1350646: Part 17 - Remove SDK DOM events modules. r=Mossop https://hg.mozilla.org/integration/mozilla-inbound/rev/5584fdcd2ee0bed1cb94f91e7fca416f93d0aa0d Bug 1350646: Part 18 - Remove SDK MVC modules. r=Mossop https://hg.mozilla.org/integration/mozilla-inbound/rev/79e77c06ff440b310bbc8f02189d1e730ff199ad Bug 1350646: Part 19 - Remove SDK passwords modules. r=Mossop https://hg.mozilla.org/integration/mozilla-inbound/rev/ee8f7fa9d4102d6b20e8e541b954be7d5290b3e8 Bug 1350646: Part 20 - Remove remaining SDK content modules. r=Mossop https://hg.mozilla.org/integration/mozilla-inbound/rev/c3108aebee35c4fc2ac04ea19fd17534bf606d64 Bug 1350646: Part 21 - Remove SDK api-utils and dependent modules. r=Mossop
|
||
Updated•7 years ago
|
Assignee: nobody → kmaglione+bmo
|
||
Comment 66•7 years ago
|
||
Backed out in https://hg.mozilla.org/integration/mozilla-inbound/rev/9f7d0c809762 for the talos damp failures you already know about, thus bug 1388954.
|
|
Assignee | |
Comment 67•7 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/1240c640559d685618e6e8ed54fe781dbbb8765b Bug 1350646: Part 1 - Remove addon-sdk moz.build generation gunk. r=Mossop https://hg.mozilla.org/integration/mozilla-inbound/rev/ec5c715bf59294fa36bf90581ccd8066d85b5a5f Bug 1350646: Part 2 - Sort SDK module sources list. r=Mossop https://hg.mozilla.org/integration/mozilla-inbound/rev/dce8af021eda7913c23ba529d81fcd49955b6b93 Bug 1350646: Part 3 - Remove sdk/system/child_process modules. r=Mossop https://hg.mozilla.org/integration/mozilla-inbound/rev/5d4019ce62a92d23cc207e07103ff6aa1ddb134e Bug 1350646: Part 4 - Remove most modules which depend on sdk/addon/*. r=Mossop https://hg.mozilla.org/integration/mozilla-inbound/rev/b9fbf0b67b0976fcf8e0b45e239333b72becbd2c Bug 1350646: Part 5 - Remove sdk/addon/* modules. r=Mossop https://hg.mozilla.org/integration/mozilla-inbound/rev/f9dfc6d93bd677795a3377ae83b246a0da20dc63 Bug 1350646: Part 6 - Remove SDK UI modules. r=Mossop https://hg.mozilla.org/integration/mozilla-inbound/rev/85d0f12f82e474c11f6e5f9eac6185de73235adf Bug 1350646: Part 7 - Remove SDK hotkey modules. r=Mossop https://hg.mozilla.org/integration/mozilla-inbound/rev/ccda4fb13271486b9840c108d0046c3aa9d13598 Bug 1350646: Part 8 - Remove SDK page-mod modules. r=Mossop https://hg.mozilla.org/integration/mozilla-inbound/rev/052102e8fdb7052e8f681f9fd3e6c4bf93f7a799 Bug 1350646: Part 9 - Remove SDK l10n modules. r=Mossop https://hg.mozilla.org/integration/mozilla-inbound/rev/2f69296ecc585d12425b124923e85ab0f6970fbe Bug 1350646: Part 10 - Remove SDK tabs/windows modules. r=Mossop https://hg.mozilla.org/integration/mozilla-inbound/rev/3580317211c8b92c14f7bb340a8bc8fe031f2c31 Bug 1350646: Part 11 - Remove SDK stylesheet modules. r=Mossop https://hg.mozilla.org/integration/mozilla-inbound/rev/da41fb3ea7a667c7b04888e917f29de84d7a73db Bug 1350646: Part 12 - Remove SDK simple-prefs module. r=Mossop https://hg.mozilla.org/integration/mozilla-inbound/rev/43af8f3bb5a160f2c45c5a3bca37a46016bff0dc Bug 1350646: Part 13 - Remove most SDK io modules. r=Mossop https://hg.mozilla.org/integration/mozilla-inbound/rev/61c5837621eca4182dc9e8f6d004b94f23710115 Bug 1350646: Part 13 - Remove several SDK test modules. r=Mossop https://hg.mozilla.org/integration/mozilla-inbound/rev/1d2459eb61b8c792e0efe5fb15ab0b98c63504c5 Bug 1350646: Part 14 - Remove SDK net/request modules. r=Mossop https://hg.mozilla.org/integration/mozilla-inbound/rev/af55bc9f7c6699058ca5e56b0bffc420be69236b Bug 1350646: Part 15 - Remove SDK storage modules. r=Mossop https://hg.mozilla.org/integration/mozilla-inbound/rev/e7b8b74b64e12b73acc1b1ad1471fc7c515e8535 Bug 1350646: Part 16 - Remove SDK notifications module. r=Mossop https://hg.mozilla.org/integration/mozilla-inbound/rev/00c584ec154f1de10a86dc1238b2b17d9630a2bd Bug 1350646: Part 17 - Remove SDK DOM events modules. r=Mossop https://hg.mozilla.org/integration/mozilla-inbound/rev/2b1a563af91505aaeaa53e0645415031e3f86e87 Bug 1350646: Part 18 - Remove SDK MVC modules. r=Mossop https://hg.mozilla.org/integration/mozilla-inbound/rev/d5030e86a3ff1b46639b74d9f6c7bac5895ce23e Bug 1350646: Part 19 - Remove SDK passwords modules. r=Mossop https://hg.mozilla.org/integration/mozilla-inbound/rev/b0592041a69e22e41fa7b770b375a5b37ccbc24e Bug 1350646: Part 20 - Remove remaining SDK content modules. r=Mossop https://hg.mozilla.org/integration/mozilla-inbound/rev/938235be307c07c84080e36bbfcd8148e417d778 Bug 1350646: Part 21 - Remove SDK api-utils and dependent modules. r=Mossop
|
||
Comment 68•7 years ago
|
||
Pushed by maglione.k@gmail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/1240c640559d Part 1 - Remove addon-sdk moz.build generation gunk. r=Mossop https://hg.mozilla.org/integration/mozilla-inbound/rev/ec5c715bf592 Part 2 - Sort SDK module sources list. r=Mossop https://hg.mozilla.org/integration/mozilla-inbound/rev/dce8af021eda Part 3 - Remove sdk/system/child_process modules. r=Mossop https://hg.mozilla.org/integration/mozilla-inbound/rev/5d4019ce62a9 Part 4 - Remove most modules which depend on sdk/addon/*. r=Mossop https://hg.mozilla.org/integration/mozilla-inbound/rev/b9fbf0b67b09 Part 5 - Remove sdk/addon/* modules. r=Mossop https://hg.mozilla.org/integration/mozilla-inbound/rev/f9dfc6d93bd6 Part 6 - Remove SDK UI modules. r=Mossop https://hg.mozilla.org/integration/mozilla-inbound/rev/85d0f12f82e4 Part 7 - Remove SDK hotkey modules. r=Mossop https://hg.mozilla.org/integration/mozilla-inbound/rev/ccda4fb13271 Part 8 - Remove SDK page-mod modules. r=Mossop https://hg.mozilla.org/integration/mozilla-inbound/rev/052102e8fdb7 Part 9 - Remove SDK l10n modules. r=Mossop https://hg.mozilla.org/integration/mozilla-inbound/rev/2f69296ecc58 Part 10 - Remove SDK tabs/windows modules. r=Mossop https://hg.mozilla.org/integration/mozilla-inbound/rev/3580317211c8 Part 11 - Remove SDK stylesheet modules. r=Mossop https://hg.mozilla.org/integration/mozilla-inbound/rev/da41fb3ea7a6 Part 12 - Remove SDK simple-prefs module. r=Mossop https://hg.mozilla.org/integration/mozilla-inbound/rev/43af8f3bb5a1 Part 13 - Remove most SDK io modules. r=Mossop https://hg.mozilla.org/integration/mozilla-inbound/rev/61c5837621ec Part 13 - Remove several SDK test modules. r=Mossop https://hg.mozilla.org/integration/mozilla-inbound/rev/1d2459eb61b8 Part 14 - Remove SDK net/request modules. r=Mossop https://hg.mozilla.org/integration/mozilla-inbound/rev/af55bc9f7c66 Part 15 - Remove SDK storage modules. r=Mossop https://hg.mozilla.org/integration/mozilla-inbound/rev/e7b8b74b64e1 Part 16 - Remove SDK notifications module. r=Mossop https://hg.mozilla.org/integration/mozilla-inbound/rev/00c584ec154f Part 17 - Remove SDK DOM events modules. r=Mossop https://hg.mozilla.org/integration/mozilla-inbound/rev/2b1a563af915 Part 18 - Remove SDK MVC modules. r=Mossop https://hg.mozilla.org/integration/mozilla-inbound/rev/d5030e86a3ff Part 19 - Remove SDK passwords modules. r=Mossop https://hg.mozilla.org/integration/mozilla-inbound/rev/b0592041a69e Part 20 - Remove remaining SDK content modules. r=Mossop https://hg.mozilla.org/integration/mozilla-inbound/rev/938235be307c Part 21 - Remove SDK api-utils and dependent modules. r=Mossop
|
||
Comment 69•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/1240c640559d https://hg.mozilla.org/mozilla-central/rev/ec5c715bf592 https://hg.mozilla.org/mozilla-central/rev/dce8af021eda https://hg.mozilla.org/mozilla-central/rev/5d4019ce62a9 https://hg.mozilla.org/mozilla-central/rev/b9fbf0b67b09 https://hg.mozilla.org/mozilla-central/rev/f9dfc6d93bd6 https://hg.mozilla.org/mozilla-central/rev/85d0f12f82e4 https://hg.mozilla.org/mozilla-central/rev/ccda4fb13271 https://hg.mozilla.org/mozilla-central/rev/052102e8fdb7 https://hg.mozilla.org/mozilla-central/rev/2f69296ecc58 https://hg.mozilla.org/mozilla-central/rev/3580317211c8 https://hg.mozilla.org/mozilla-central/rev/da41fb3ea7a6 https://hg.mozilla.org/mozilla-central/rev/43af8f3bb5a1 https://hg.mozilla.org/mozilla-central/rev/61c5837621ec https://hg.mozilla.org/mozilla-central/rev/1d2459eb61b8 https://hg.mozilla.org/mozilla-central/rev/af55bc9f7c66 https://hg.mozilla.org/mozilla-central/rev/e7b8b74b64e1 https://hg.mozilla.org/mozilla-central/rev/00c584ec154f https://hg.mozilla.org/mozilla-central/rev/2b1a563af915 https://hg.mozilla.org/mozilla-central/rev/d5030e86a3ff https://hg.mozilla.org/mozilla-central/rev/b0592041a69e https://hg.mozilla.org/mozilla-central/rev/938235be307c
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox57:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
|
||
Updated•2 years ago
|
Performance Impact: --- → P1
Whiteboard: [qf:p1]
You need to log in
before you can comment on or make changes to this bug.
Description
•