Xidorn Quan [:xidorn] UTC+11 Assignee
	Description • 7 years ago

With bug 1349024, we are going to turn off xml:base for style attribute. If that doesn't lead to significant issues, we probably should have it ride the train to completely unship xml:base for style attribute.

	Xidorn Quan [:xidorn] UTC+11 Assignee
	Comment 1 • 7 years ago

miketaylr, have you seen any compat issue reported which may be related to bug 1349024 disabling xml:base for style attribute? If not, should we try moving forward in this bug to have it rid the train to beta and release?

	Julien Cristau [:jcristau]
	Comment 2 • 7 years ago

Adding this to the 55 tracking list so it's on the radar for release management.

	Mike Taylor [:miketaylr]
	Comment 3 • 7 years ago

I'm not aware of any reports. Dennis, Tom, anything I might have missed?

	Thomas Wisniewski
	Comment 4 • 7 years ago

Same here; I don't recall any reports related to this.

	Dennis Schubert [:denschub]
	Comment 5 • 7 years ago

Have not found or seen anything, no.

	Xidorn Quan [:xidorn] UTC+11 Assignee
	Comment 6 • 7 years ago

OK, then let's do it.

	Xidorn Quan [:xidorn] UTC+11 Assignee
	Comment 8 • 7 years ago

jet, although you suggested me that we only do this for beta for now, it doesn't seem to me it is a usual pattern to have separate settings for beta and release, and I think it makes sense. We probably want to keep beta and release consistent so that we know the status of release from beta.

	Jet Villegas (inactive)
	Comment 9 • 7 years ago
mozreview-review

Comment on attachment 8872196 [details]
Bug 1350521 - Turn off xml:base for style attribute by default for all channels.

https://reviewboard.mozilla.org/r/143650/#review148210

r+

	Pulsebot
	Comment 10 • 7 years ago

Pushed by xquan@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/8feddea7052d
Turn off xml:base for style attribute by default for all channels. r=jet

	Ryan VanderMeulen [:RyanVM]
	Comment 11 • 7 years ago
bugherder

https://hg.mozilla.org/mozilla-central/rev/8feddea7052d

	Chris Mills [:cmills]
	Comment 12 • 7 years ago

We've not even got any documentation for xml:base anymore (the page simply redirects to the page for <base>), so I've just added a note to the Fx55 rel notes:

https://developer.mozilla.org/en-US/Firefox/Releases/55#HTML

Let me know if that's OK. Thanks!

	Xidorn Quan [:xidorn] UTC+11 Assignee
	Comment 13 • 7 years ago

That looks good, thanks!