Closed
Bug 1350096
Opened 7 years ago
Closed 7 years ago
Once you've set a single Thunderbird tracking flag, the "Firefox Tracking Flags" section changes name to "Thunderbird Tracking Flags"
Categories
(bugzilla.mozilla.org :: General, defect)
Tracking
()
VERIFIED
FIXED
People
(Reporter: dholbert, Assigned: dylan)
References
Details
Attachments
(1 file)
1.43 KB,
patch
|
glob
:
review+
|
Details | Diff | Splinter Review |
STR: 1. Edit a bug in Core|Layout (or probably any Core bug) 2. Toggle open the section called "Firefox Tracking Flags". 3. Set all of the available version tracking flags, including the ones for Thunderbird. Specifically, set all of the following flags to "affected", for example: firefox52 firefox53 firefox54 firefox55 firefox-esr45 firefox-esr52 thunderbird_esr45 thunderbird_esr52 4. Click "Save Changes". 5. Once the page has refreshed, look at that same section of the page with the tracking flags. ACTUAL RESULTS: It's changed names! It's now labeled "Thunderbird Tracking Flags" EXPECTED RESULTS: It should not have changed names. It seems like perhaps we're assuming that a bugs with *any* Thunderbird status flag set is a Thunderbird-specific bug. Instead, I'd suggest that we should only make that assumptions for bugs that have *only* thunderbird status flags set.
Reporter | ||
Comment 1•7 years ago
|
||
(I just ran into this on bug 1349816, though you might not be able to see that bug because it's marked sec-sensitive.)
Assignee | ||
Updated•7 years ago
|
Assignee: nobody → dylan
Assignee | ||
Comment 2•7 years ago
|
||
Much as it pains me, I can fix this ahead of removing the ugly mass of logic in the templates.
Assignee | ||
Comment 3•7 years ago
|
||
Attachment #8851022 -
Flags: review?(glob)
Comment on attachment 8851022 [details] [diff] [review] 1350096_1.patch Review of attachment 8851022 [details] [diff] [review]: ----------------------------------------------------------------- r=glob ::: extensions/BugModal/template/en/default/bug_modal/edit.html.tmpl @@ +136,4 @@ > ELSIF row.name.search("^seamonkey"); > + scores.seamonkey = scores.seamonkey + 1; > + ELSE; > + scores.firefox = scores.firefox + 1; these could be booleans instead of counters
Attachment #8851022 -
Flags: review?(glob) → review+
Assignee | ||
Comment 5•7 years ago
|
||
Keeping them as a counter for now. Might fix when I rewrite this in perl. To git@github.com:mozilla-bteam/bmo.git 0abf244..6de88ac master -> master
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•