Open Bug 1349863 Opened 7 years ago Updated 2 years ago

Enable test262 agent tests (Atomics/wait, Atomics/notify) in browser integration testing

Categories

(Core :: JavaScript Engine, enhancement, P3)

enhancement

Tracking

()

Tracking Status
firefox55 --- affected

People

(Reporter: lth, Unassigned)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Currently (see bug 1346068 comment 14) agent tests are disabled in the browser because the test cases are not suitable for the browser and the $262.agent framework is insufficient for dealing with a browser.

Work items:
 
- fix $262.agent framework upstream (tc39/test262#928)
- fix the test cases upstream (ditto)
- fix our implementation of $262.agent in js/src/tests/test262-host.js and
  js/src/tests/test262/shell.js
- remove the opt-outs in js/src/tests/jstests.list
This has a new harness with a new API and rewritten test cases.  It is *roughly* right and it passes locally when run in a browser with a simplified context, but fails on try, see the links in previous comments.

The error is invariably that 'no output' is produced for the test cases.  I think that what's most likely happening is that when $262.agent.start() returns to the event loop, as it must for the workers to be created properly, and also when it tries to wait for results from the workers, then the test runner may conclude that the test is done (because the script returned).  But the only way to determine that is either to see test output, or to time out.
Assignee: nobody → lhansen
I'm updating test262. It looks like the API being tested here has changed, and basically none of the tests will run for us anymore. I'm going to disable them in jstests.list.
Summary: Enable test262 agent tests (Atomics/wait, Atomics/wake) in browser integration testing → Enable test262 agent tests (Atomics/wait, Atomics/notify) in browser integration testing
Bug 1470490 is about renaming wait as notify, I hope nothing else is a problem.  And the rename (really - introduce an alias, for now) is all but trivial.  And that bug should be unblocked now.
Depends on: 1470490
Blocks: resab
Assignee: lhansen → nobody
No longer blocks: resab

If this should continue to block bug 1477743 let me know. In that case we need to get this prioritized somehow.

Blocks: 1563480
Severity: normal → S3
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: