Mihai Boldan, Desktop QA [:mboldan] Reporter
	Description • 7 years ago

[Affected versions]:
- Firefox 55.0a1 (2017-03-21)

[Affected platforms]:
- Windows 10x64, Ubuntu 14.04x64, Mac OS X 10.11

[Steps to reproduce]:
1. Launch Firefox.
2. Go to https://opentokrtc.com/ and start a meeting with other user.

[Expected result]:
- The meeting starts correctly and audio/video is working accordingly.

[Actual result]:
- The meeting starts, but the Nightly user is not able to see or hear the other user. Error message is displayed - https://i.imgur.com/awwJocV.png .

[Regression range]:
- This is a regression. 
- Last good revision: 186d77e982061443dc7ef1dd662da59b2928de18
- First bad revision: b954d11db3475bc07a91c8ff2febd0febad67ea7
Pushlog:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=186d77e982061443dc7ef1dd662da59b2928de18&tochange=b954d11db3475bc07a91c8ff2febd0febad67ea7
It seems that Bug 1323723 caused this issue.

[Additional notes]:
- The issue is not reproducible on Firefox 53.0b4 or Firefox 52.0.1 builds.

	Randell Jesup [:jesup] (needinfo me)
	Comment 1 • 7 years ago

Nils, byron - can you look at this, since it's a new regression [probably from the a=setup changes]. Thanks

	Nils Ohlmeier [:drno]
	Comment 2 • 7 years ago

So this a TokBox issue. The TokBox offer has no a=setup in it at all.

Gustavo: TokBox should add the s=setup attribute to it's offers ASAP :-)

	Jose Carlos Pujol
	Comment 3 • 7 years ago

Hey! Thanks for letting us know. We already fixed it, but will take some weeks until it reaches production. I will post something when it reaches our nightly environment and also when it goes to production.

Regarding this, I have a question: when sending an offer to the receiver, is there any case in which the browser will answer with "a=setup:passive"? I don't see why this is interesting, but I am just trying to understand cases that I am not able to foresee.

	oscar.divorra
	Comment 4 • 7 years ago

Jose Carlos: https://tools.ietf.org/html/rfc5763
"The answerer MUST use either a setup attribute value of setup:active or setup:passive.  Note that if the answerer uses setup:passive, then the DTLS handshake will not begin until the answerer is received, which adds additional latency. setup:active allows the answer and the DTLS handshake to occur in parallel.  Thus, setup:active is RECOMMENDED."

Good call guys. thx.

	Jose Carlos Pujol
	Comment 5 • 7 years ago

Exactly. Even though "passive" is allowed, is there any reason not to use "active" all the time?

	Nils Ohlmeier [:drno]
	Comment 6 • 7 years ago

(In reply to Jose Carlos Pujol from comment #5)
> Exactly. Even though "passive" is allowed, is there any reason not to use
> "active" all the time?

Yes. Renegotiation. 

In the normal initial O/A the offerer becomes the passive DTLS side. If the active DTLS side (the initial answerer) creates a new offer it is suppose to use 'actpass' again per JSEP spec. Now the answerer is not allowed to switch DTLS roles if no ICE restart is involved.
Working in bug 1329028 on implementing that logic right now, because so far Firefox always answers with 'active', which is not always right.

Thanks for the status updates.

Lowering priority since this is not really a Firefox bug.

	Jose Carlos Pujol
	Comment 7 • 7 years ago

Thanks! That makes sense

	Jose Carlos Pujol
	Comment 8 • 7 years ago

We deployed the patch in our nightly version: https://meet.tokbox.com/testingff. It should go to production in a couple of weeks. Thanks again

	Nathan Froyd [:froydnj]
	Comment 9 • 7 years ago

(In reply to Nils Ohlmeier [:drno] from comment #6)
> Lowering priority since this is not really a Firefox bug.

Since this isn't a Firefox bug, is there value in keeping this bug open?

	Nils Ohlmeier [:drno]
	Comment 10 • 7 years ago

Yes I think we can close it now.
Since this was never a bug on the Firefox side I'm going to say it's invalid (although the bug report was very valuable to TokBox I assume :-) ).

	RBadri
	Comment 11 • 7 years ago

Thanks so much guys. Although this was an issue on the TokBox's side, appreciate Mozilla helping us resolve this.