Honza Bambas (:mayhemer) Reporter
	Description • 7 years ago

Scenario:
- a "New to bugzilla" user reports a bug
- I ask the user for some info (logs, retest etc) and raise NI on him/her
- the reporter answers, but the NI flag is left raised

I don't think users deliberately uncheck the "Clear the needinfo request for" checkbox.  Rather is something wrong with the UI.

I can see this mainly with new users.  No idea if this is caused by the new UI or something else.  Could it be that such a user refreshes the page with F5, which doesn't update fields on the page to reflect the current bug state and the "Clear the needinfo request for" check box is left unchecked from some reason?

	Honza Bambas (:mayhemer) Reporter
	Comment 1 • 7 years ago

An example comment where NI was not dropped:
https://bugzilla.mozilla.org/show_bug.cgi?id=1344086#c6

	Dylan Hardison [:dylan] (he/him)
	Comment 2 • 7 years ago

Hey other me, you are uniquely suited to test this!

	Dylan Hardison [:dylanAtHome]
	Comment 3 • 7 years ago

Yep, it seems to not be checked if the account doesn't have editbugs

	Dylan Hardison [:dylanAtHome]
	Comment 4 • 7 years ago

Yep, now that I have editbugs it is checked.

	Honza Bambas (:mayhemer) Reporter
	Comment 5 • 7 years ago

Thanks Dylan!

	David Lawrence [:dkl]
	Comment 6 • 7 years ago

It's actually 'canconfirm', not 'editbugs' but 'editbugs' automatically gives you 'canconfirm' which explains your change.

https://github.com/mozilla-bteam/bmo/blob/master/extensions/Needinfo/template/en/default/bug/needinfo.html.tmpl#L161

What it should use maybe is ($flag->requestee->id == $user->id || $user->in_group('canconfirm')) since the requestee should be able to clear their own needinfo at least.

dkl

	Emma Humphries ☕️🎸🧞‍♀️✨ (she/they) [:emceeaich] (Pacific Time) use needinfo
	Comment 7 • 7 years ago

Is this a regression from the old bug page?

	Emma's Evil Twin (don't assign me bugs or needinfo, I'm just here for testing.)
	Comment 8 • 7 years ago

No. It's not a regression.

	Dylan Hardison [:dylan] (he/him)
	Comment 10 • 7 years ago

Comment on attachment 8846938 [details] [review]
github pull request

r=dylan

	Dylan Hardison [:dylan] (he/him)
	Comment 11 • 7 years ago

To git@github.com:mozilla-bteam/bmo.git
   ac85576..5bfe41d  master -> master

	Dylan Hardison [:dylan] (he/him)
	Comment 12 • 7 years ago

Hey dylanAtHome, can you check if this is working now?

	Dylan Hardison [:dylanAtHome]
	Comment 13 • 7 years ago

The checkbox was pre-checked, other-me!

	Dylan Hardison [:dylan] (he/him)
	Comment 15 • 7 years ago

Testing something, disregard.

	Dylan Hardison [:dylanAtHome]
	Comment 16 • 7 years ago

It looks like the canconfirm logic is wrong...