Bogdan Maris, Desktop QA Reporter
	Description • 7 years ago

[Affected versions]:
- Firefox 51.0.1
- Firefox 52.0
- Firefox 53 beta 1
- latest Developer Edition 54.0a2
- latest Nightly 55.0a1

[Affected platforms]:
- Windows 10 64bit
- Ubuntu 16.04
- macOS 10.12.3

[Steps to reproduce]:
1. Start Firefox
2. Change 'layout.css.devPixelsPerPx' value to '1.5', '1.2', '1.75'
3. Drag a few more tools to navigation bar (zoom controls, bookmarks etc)

[Expected result]:
- All the tools have the same height (the width could differ though for example in zoom controls).

[Actual result]:
- A different tools have different values (18x18, 18.3334x18.3336, 18.6667x18.66667 and could be more, I did not check all the tools)

[Regression range]:
- It's tough to check for a regression range here since different tools could have changed the size in different ranges.

I did found a range for the difference between "Bookmark this page" and "Show your bookmarks"

Last good revision: cef11c3e86c3 (2015-07-06)
First bad revision: e7e69cc8c07b (2015-07-07)
Pushlog:
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=cef11c3e86c3&tochange=e7e69cc8c07b

I think the culprit could be:
5092740fe8bd	Dão Gottwald — Bug 1179295 - Let toolbar buttons match the location and search bar's minimum height on Windows 10. r=jaws

[Additional notes]:
- I noticed that for different values of 'layout.css.devPixelsPerPx' there is a different value for tools (Downloads hoverfeedback icon remains to 18x18 regardless of Pixel value but "Bookmark this page" changes).
- In windows the difference between "Bookmark this page" and "Show your bookmarks" is visible with the naked eye, others could not, so I used Browser Toolbox to check for hoverfeedback size.

	Julien Cristau [:jcristau]
	Comment 1 • 7 years ago

Too late for firefox 52, mass-wontfix.