Henrik Skupin [:whimboo][⌚️UTC+1] Assignee
	Description • 7 years ago

The following testcase is failing because get() never returns:

def test_load_same_image_document_twice(self):
    self.marionette.navigate(self.fixtures.where_is("black.png"))
    self.assertIn("black.png", self.marionette.title)
    self.marionette.navigate(self.fixtures.where_is("black.png"))
    self.assertIn("black.png", self.marionette.title)

A fix for bug 1333458 should cover this situation.

	Andreas Tolfsen ❲:ato❳
	Comment 1 • 7 years ago

We do have a test for navigating _between_ ImageDocument’s:

>     def test_image_document_to_image_document(self):
>         self.marionette.navigate(self.fixtures.where_is("test.html"))
> 
>         self.marionette.navigate(self.fixtures.where_is("white.png"))
>         self.assertIn("white.png", self.marionette.title)
>         self.marionette.navigate(self.fixtures.where_is("black.png"))
>         self.assertIn("black.png", self.marionette.title)

A fix for that was added in https://bugzilla.mozilla.org/show_bug.cgi?id=1322772, which could give useful clues.

	Henrik Skupin [:whimboo][⌚️UTC+1] Assignee
	Comment 2 • 7 years ago

Please see the topic of this bug. It is the SAME image document. In your example we have two different images.

	Andreas Tolfsen ❲:ato❳
	Comment 3 • 7 years ago

Yes, that’s what I said (-:

	Henrik Skupin [:whimboo][⌚️UTC+1] Assignee
	Comment 4 • 7 years ago

The problem here is actually that we miss to remove a former progress listener in case of get commands for image documents. I noticed that while working on bug 1330348, so it will be a side-along fix there.

	Henrik Skupin [:whimboo][⌚️UTC+1] Assignee
	Comment 5 • 7 years ago

This is fixed now given that bug 1330348 landed on mozilla-central.