Emil Ghitta, QA [:emilghitta] Reporter
	Description • 7 years ago

[Affected versions]:
Firefox 52.0 (Build Id:20170302120751)
Firefox 53.0a2 (Build Id:20170303004003)
Firefox 54.0a1 (Build Id:20170303030202)
Firefox 52.0esr (Build Id:20170303022339)
Firefox 45.8.0esr (Build Id:20170301181722)

[Affected platforms]:
Windows 10.

[Steps to reproduce]:
1.Launch Microsoft Edge 38.14393.0.0.
2.Launch Firefox.
3.Access the about:preferences#security page.
4.Click on the “Saved Logins” button.
5.Click the “Import” button.
6.Observe that Firefox freezes and the import Wizard opens after a significant delay.

[Expected result]:
The import Wizard opens right after the “Import” button was clicked.

[Actual result]:
Firefox freezes and the import Wizard opens after a significant delay.

[Regression range]:
It seems that this is an old regression:
Last good revision: ac338559876df7b2e81388f2aac28d2e95ceb5ff (2016-02-08)
First bad revision: d1a54ae63da7ebc4bc1eeb5b613e8ec29bfcb80a (2016-02-09)
Pushlog:
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=ac338559876df7b2e81388f2aac28d2e95ceb5ff&tochange=d1a54ae63da7ebc4bc1eeb5b613e8ec29bfcb80a


[Additional information]:
I have managed to reproduce this issue while Microsoft Edge 38.14393.0.0 is opened in the background.
This issue is not reproducible on Linux OS and Mac OS.

	Dão Gottwald [:dao]
	Comment 2 • 7 years ago
mozreview-review

Comment on attachment 8845024 [details]
Bug 1344644 - stop supporting outdated Edge bookmarks format to avoid hangs trying to open bookmarks database when Edge is open,

https://reviewboard.mozilla.org/r/118264/#review120138

	Pulsebot
	Comment 3 • 7 years ago

Pushed by gijskruitbosch@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/46115aeb4216
stop supporting outdated Edge bookmarks format to avoid hangs trying to open bookmarks database when Edge is open, r=dao

	Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)
	Comment 4 • 7 years ago
bugherder

https://hg.mozilla.org/mozilla-central/rev/46115aeb4216

	Ryan VanderMeulen [:RyanVM]
	Comment 5 • 7 years ago

Probably not worth the backport to ESR45, but seems worth the backport for Aurora/Beta/ESR52 at least.

	:Gijs (he/him) Assignee
	Comment 6 • 7 years ago

Comment on attachment 8845024 [details]
Bug 1344644 - stop supporting outdated Edge bookmarks format to avoid hangs trying to open bookmarks database when Edge is open,

Approval Request Comment
[Feature/Bug causing the regression]: importing browser data from Edge
[User impact if declined]: Firefox hangs when opening the dialog (and maybe when trying to do automigration, too)
[Is this code covered by automated tests?]: yes, but none that run while Edge is open
[Has the fix been verified in Nightly?]: not yet
[Needs manual test from QE? If yes, steps to reproduce]: see comment #0.
[List of other uplifts needed for the feature/fix]: nope
[Is the change risky?]: not really
[Why is the change risky/not risky?]: We're removing the ability to import bookmarks from disk in the way that Edge used to store them, and therefore no longer check for the presence of the Edge database before showing the migration dialog, which means it appears more quickly.
[String changes made/needed]: no

	Julien Cristau [:jcristau]
	Comment 7 • 7 years ago

Comment on attachment 8845024 [details]
Bug 1344644 - stop supporting outdated Edge bookmarks format to avoid hangs trying to open bookmarks database when Edge is open,

don't migrate bookmarks from edge in 53 and 54

Should be in 53.0b3

	Ryan VanderMeulen [:RyanVM]
	Comment 8 • 7 years ago
bugherder uplift

https://hg.mozilla.org/releases/mozilla-aurora/rev/ae18402a0a32

	Ryan VanderMeulen [:RyanVM]
	Comment 9 • 7 years ago
bugherder uplift

https://hg.mozilla.org/releases/mozilla-beta/rev/1bea5e99808b

	Nawaf Chowdhury Akash
	Comment 10 • 7 years ago

I've successfully reproduced this bug in firefox 54.0a1 (2017-03-03) with windows 10, 32 bit.

The bug is verified as fixed in latest nightly 55.0a1 .

Build Id : 20170315030215

User agent : Mozilla/5.0 (Windows NT 10.0; rv:55.0) Gecko/20100101 Firefox/55.0

[bugday-20170315]

	Andrei Vaida [:avaida]
	Comment 11 • 7 years ago

Let's make sure this works as intended on 53 as well.

Also updating status flags based on Comment 10 -- thank you for helping out with verification here, Akash!

	:Gijs (he/him) Assignee
	Comment 12 • 7 years ago

Comment on attachment 8845024 [details]
Bug 1344644 - stop supporting outdated Edge bookmarks format to avoid hangs trying to open bookmarks database when Edge is open,

Oops, I missed the request for ESR52 uplift/consideration.

[Approval Request Comment]
If this is not a sec:{high,crit} bug, please state case for ESR consideration: significant performance impact on initial browser import
User impact if declined:  ditto
Fix Landed on Version: 55, uplifted to 53
Risk to taking this patch (and alternatives if risky): pretty low. We stop supporting old-style edge bookmark imports (from very old versions of Windows 10).
String or UUID changes made by this patch: nope

See https://wiki.mozilla.org/Release_Management/ESR_Landing_Process for more info.

	:Gijs (he/him) Assignee
	Comment 13 • 7 years ago

Ni me to figure out if we can avoid this hang when actually importing from Edge.

	Emil Ghitta, QA [:emilghitta] Reporter
	Comment 14 • 7 years ago

I have verified that this issue is not reproducible using Firefox 53.0b5 (Build Id:20170320143328)and Firefox
54.0a2(Build Id:20170323004002)on Windows 10 64bit.

	Julien Cristau [:jcristau]
	Comment 15 • 7 years ago

Comment on attachment 8845024 [details]
Bug 1344644 - stop supporting outdated Edge bookmarks format to avoid hangs trying to open bookmarks database when Edge is open,

don't import old edge bookmarks that cause us to hang.  verified in 53/54/55, let's take this in 52.1.0esr too.

	Carsten Book [:Tomcat]
	Comment 16 • 7 years ago
bugherder uplift

https://hg.mozilla.org/releases/mozilla-esr52/rev/cac0735c228f

	Andrei Vaida [:avaida]
	Comment 17 • 7 years ago

Emil, could you please take a look at this on 52.1esr as well?

	Emil Ghitta, QA [:emilghitta] Reporter
	Comment 18 • 7 years ago

I have verified that this issue is not reproducible on Firefox 52.1.0esr (Build Id: 20170410145022) using Windows 10 64bit.