Closed
Bug 1343845
Opened 7 years ago
Closed 7 years ago
bug status summary does not work when logged out
Categories
(bugzilla.mozilla.org :: Readable Bug Statuses, defect)
Tracking
()
VERIFIED
FIXED
People
(Reporter: glob, Assigned: emceeaich)
Details
Attachments
(1 file)
steps to reproduce: 1. load any bug 1319452 while logged in 2. observe the status has "Status (bug RESOLVED as FIXED for Firefox 53)" 3. load the same bug in a private browsing window or after logging out expected: "Status (bug RESOLVED as FIXED for Firefox 53)" actual: "Status ()"
Assignee | ||
Comment 1•7 years ago
|
||
Look at console to see what, if any errors are happening.
Flags: needinfo?(ehumphries)
sorry, should have mentioned it in my initial report - there's no js errors in the console.
Assignee | ||
Comment 3•7 years ago
|
||
The function to generate the readable status message never executes: extensions/BugModal/web/bug_modal.js: lines 778-780 var rbs = $("#readable-bug-status"); var rbs_text = bugzillaReadableStatus.readable(rbs.data('readable-bug-status')); rbs.text(rbs_text); It is in a section of code which never executes unless there's a valid login session. At line 452 in the same file: if (BUGZILLA.user.id === 0) return; I'll attempt a patch and see what breaks if I move those three lines up;
Assignee: nobody → ehumphries
Flags: needinfo?(ehumphries)
Assignee | ||
Comment 4•7 years ago
|
||
GitHub pull request.
Assignee | ||
Updated•7 years ago
|
Attachment #8845235 -
Flags: review?(dylan)
Comment 5•7 years ago
|
||
Comment on attachment 8845235 [details] [review] Patch git commit --amend the commit, the commit message should be in the form that comes out of the "Copy tp clipboard" button the bug page. The subsequent lines can have any format
Attachment #8845235 -
Flags: review?(dylan) → review-
Assignee | ||
Comment 6•7 years ago
|
||
Updated the commit message.
Assignee | ||
Updated•7 years ago
|
Attachment #8845235 -
Flags: review- → review?(dylan)
Comment 7•7 years ago
|
||
Comment on attachment 8845235 [details] [review] Patch r=dylan, will commit soon
Attachment #8845235 -
Flags: review?(dylan) → review+
Comment 8•7 years ago
|
||
To git@github.com:mozilla-bteam/bmo.git dfb694156..badbd7739 master -> master
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Updated•7 years ago
|
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•