Closed Bug 1343792 Opened 7 years ago Closed 6 years ago

Different colors in tab border between Compact Light and Dev edition theme

Categories

(Firefox :: Theme, defect, P3)

defect

Tracking

()

RESOLVED WORKSFORME
Tracking Status
firefox51 --- unaffected
firefox52 --- unaffected
firefox53 --- fix-optional
firefox54 --- fix-optional
firefox55 --- fix-optional

People

(Reporter: cgeorgiu, Unassigned)

References

Details

(Keywords: regression)

Attachments

(1 file)

[Affected versions]:
- latest Nightly 54.0a1
- latest Aurora 53.0a2

[Affected platforms]:
- Windows 7 x64
- Windows 8.1 x64
- macOS 10.12.1

[Steps to reproduce]:
1. Start Firefox.
2. Enable Compact Light theme from about:addons.
   - inspect the tab border color

[Expected result]:
- The tab border has a dark color, same like Dev edition theme had, before it became Compact Theme. (see the screenshot attached)

[Actual result]:
- The tab border has a grey color.

[Regression range]:
- https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=fb6a2290e35d17db060dfe3c541ca04f3a6f9230&tochange=4bbe0c7e648909d6118e9cc4eea14296569db80b

[Additional notes]:
- I can only see this issue with Compact Light theme
- this is not reproducible on Windows 10 and Ubuntu LTS
Has STR: --- → yes
This is a polish issue, P3. 

Aside: is it me or does it look better now? Is this an intentional change?
Priority: -- → P3
(In reply to Jeff Griffiths (:canuckistani) (:⚡︎) from comment #1)
> This is a polish issue, P3. 
> 
> Aside: is it me or does it look better now? Is this an intentional change?

I think it looks worse, the non-transparent grey clashes with the darker border at the edge (on the left side of window).

That said, I think this is win8-specific, so meh.
Dao, is this likely to be fixed for 54?
Flags: needinfo?(dao+bmo)
(In reply to Nathan Froyd [:froydnj] from comment #3)
> Dao, is this likely to be fixed for 54?

Probably easy to fix, but so far nobody has looked into this and it's unlikely to become a priority, since things will change again in Firefox 57.
Flags: needinfo?(dao+bmo)
That's unfortunate, but that's also life.  Marking fix-optional, then.
Is this still relevant ?
Flags: needinfo?(ciprian.georgiu)
No, the issue is not reproducible anymore on latest Nightly.
Flags: needinfo?(ciprian.georgiu)
Resolving per comment #7.
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: