Closed Bug 1339672 Opened 7 years ago Closed 5 years ago

[css-grid] grid-auto-columns/rows should accept multiple track-size values

Categories

(Core :: CSS Parsing and Computation, defect, P3)

Product:
Core
Component:
CSS Parsing and Computation
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla70
Tracking Flags:
Tracking Status
firefox54 --- wontfix
firefox70 --- fixed

People

(Reporter: MatsPalmgren_bugz, Assigned: boris)

References

(Blocks 1 open bug)

Details

(Keywords: dev-doc-complete, DevAdvocacy, testcase, Whiteboard: [devRel:P1][wptsync upstream])

Attachments

(3 files)

testcase
793 bytes, text/html
Details
Bug 1339672 - Support multiple track sizes for grid-auto-{columns|rows}.
47 bytes, text/x-phabricator-request
Details | Review
Screenshot of subgrid and multipe track-sizes
111.15 KB, image/png
Details
Attached file testcase — 
https://drafts.csswg.org/css-grid/#auto-tracks
"
Value: 	<track-size>+
"

(This is an old Grid spec change that happened together with the "simplified subgrid"
changes so we apparently missed it.)
Blocks: css-grid
Keywords: DevAdvocacy
Whiteboard: [devRel:P1]
Blink/Edge/WebKit accept multiple track-size values.
I've just hit this bug too - here's a CodePen -- https://codepen.io/sturobson/pen/b9b47e83d372cc4834aed7585e0e8b52?editors=1100

Would love this to be working :)

This becomes an issue for the classic card-layout subgrid use-case. See https://codepen.io/mirisuzanne/pen/XQGJbe?editors=0100 where it is impossible to establish individual sizing for the three repeating auto-generated rows that would be required.

Assignee: nobody → boris.chiou

Looks like this is a web-compatible issue now, and I guess what we need is update the types of grid-auto-columns & grid-auto-rows, and update nsGridContainerFrame::TrackSizingFunctions to accept an array of auto size.

Support <track-size>+ on the implicit track sizing properties,
grid-auto-columns and grid-auto-rows.

The screenshot of https://codepen.io/mirisuzanne/pen/XQGJbe?editors=0100 after applying the patch.

Keywords: dev-doc-needed
Pushed by bchiou@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/4e4bb211b673
Support multiple track sizes for grid-auto-{columns|rows}. r=emilio,mats
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/18302 for changes under testing/web-platform/tests
Whiteboard: [devRel:P1] → [devRel:P1][wptsync upstream]
Upstream web-platform-tests status checks passed, PR will merge once commit reaches central.

https://hg.mozilla.org/mozilla-central/rev/4e4bb211b673

Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox70: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla70
Depends on: 1593796
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: