Closed
Bug 1338144
Opened 7 years ago
Closed 7 years ago
disable service workers and push notifications on 52 ESR
Categories
(Core :: DOM: Service Workers, defect, P1)
Core
DOM: Service Workers
Tracking
()
People
(Reporter: bkelly, Assigned: baku)
References
Details
(Keywords: dev-doc-complete, site-compat)
Attachments
(1 file, 1 obsolete file)
18.93 KB,
patch
|
Details | Diff | Splinter Review |
As discussed on dev-platform we would like to disable service workers in FF 52 ESR. We expect to make large changes to SW and it would be difficult to maintain uplifts across this architectural change. We would also need to disable push notifications since they require service workers.
Updated•7 years ago
|
status-firefox-esr52:
--- → affected
tracking-firefox-esr52:
--- → 52+
Comment 1•7 years ago
|
||
Posted the site compatibility doc: https://www.fxsitecompat.com/en-CA/docs/2017/service-workers-and-push-notifications-are-disabled-on-firefox-52-esr/
Keywords: dev-doc-needed,
site-compat
Reporter | ||
Comment 3•7 years ago
|
||
Andrew, can you find someone to do this? Probably have to fight with tests a bit.
Flags: needinfo?(overholt)
Comment 4•7 years ago
|
||
baku, can you help out here? It's pretty time-sensitive.
Flags: needinfo?(overholt) → needinfo?(amarchesini)
Assignee | ||
Comment 5•7 years ago
|
||
it seems to me that SWs are disabled in ESR-52: https://hg.mozilla.org/releases/mozilla-esr52/file/tip/modules/libpref/init/all.js#l155
Flags: needinfo?(amarchesini)
Assignee | ||
Updated•7 years ago
|
Flags: needinfo?(bkelly)
Reporter | ||
Comment 6•7 years ago
|
||
Maybe the prefs were imported from 45esr? Do we need any prefs set for notifications?
Flags: needinfo?(bkelly)
Comment 7•7 years ago
|
||
(In reply to Ben Kelly [:bkelly] from comment #6) > Maybe the prefs were imported from 45esr? Do we need any prefs set for > notifications? We don't want to turn off web notifications entirely, right? Just notifications triggered from push messages?
Flags: needinfo?(bkelly)
Reporter | ||
Comment 8•7 years ago
|
||
Right push notifications. I thought there was a separate flag for that, but I don't really know.
Flags: needinfo?(bkelly)
Comment 9•7 years ago
|
||
Kit would know if we have a separate pref for Push that needs to be flipped for 52esr.
Flags: needinfo?(kit)
Comment 11•7 years ago
|
||
(In reply to Andrea Marchesini [:baku] from comment #5) > it seems to me that SWs are disabled in ESR-52: > https://hg.mozilla.org/releases/mozilla-esr52/file/tip/modules/libpref/init/ > all.js#l155 browser/app/profile/firefox.js enables them, afaict.
Updated•7 years ago
|
Comment 12•7 years ago
|
||
ESR52 goes to build on Monday, any chance we could have that patch before then?
Flags: needinfo?(amarchesini)
Assignee | ||
Comment 13•7 years ago
|
||
Patch written, I'm waiting to see some results on treeherder
Flags: needinfo?(amarchesini)
Assignee | ||
Comment 14•7 years ago
|
||
Assignee: nobody → amarchesini
Attachment #8840488 -
Flags: review?(catalin.badea392)
Comment 15•7 years ago
|
||
Comment on attachment 8840488 [details] [diff] [review] disable.patch Review of attachment 8840488 [details] [diff] [review]: ----------------------------------------------------------------- lgtm
Attachment #8840488 -
Flags: review?(catalin.badea392) → review+
Assignee | ||
Comment 16•7 years ago
|
||
Comment on attachment 8840488 [details] [diff] [review] disable.patch We discuss this issue on dev-platform. We are going to do a big refactoring of ServiceWorker code and we cannot port it to ESR52. Better to disable SW now.
Attachment #8840488 -
Flags: approval-mozilla-esr52?
Comment 17•7 years ago
|
||
Comment on attachment 8840488 [details] [diff] [review] disable.patch disable service workers and push notification for esr52
Attachment #8840488 -
Flags: approval-mozilla-esr52? → approval-mozilla-esr52+
Assignee | ||
Comment 18•7 years ago
|
||
Attachment #8840488 -
Attachment is obsolete: true
Comment 19•7 years ago
|
||
bugherder uplift |
https://hg.mozilla.org/releases/mozilla-esr52/rev/470b33508a69
Flags: in-testsuite-
Updated•7 years ago
|
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Comment 20•7 years ago
|
||
Verified fixed on 52.0.0esr-build4 using: Windows 7 x64, Windows 10 x64, Ubuntu 16.04 x64 and macOS 10.12.3. Push and ServiceWorkers are disabled on 52esr.
Status: RESOLVED → VERIFIED
Comment 21•7 years ago
|
||
Chris Mills has updated all the compat tables for Service Workers and Push to mention this. \o/ https://developer.mozilla.org/en-US/docs/Web/API/Service_Worker_API#Browser_compatibility et al https://developer.mozilla.org/en-US/docs/Web/API/Push_API#Browser_compatibility et al
Keywords: dev-doc-needed → dev-doc-complete
You need to log in
before you can comment on or make changes to this bug.
Description
•