Ben Kelly [:bkelly, not reviewing] Reporter
	Description • 7 years ago

As discussed on dev-platform we would like to disable service workers in FF 52 ESR.  We expect to make large changes to SW and it would be difficult to maintain uplifts across this architectural change.

We would also need to disable push notifications since they require service workers.

	Kohei Yoshino [:kohei]
	Comment 1 • 7 years ago

Posted the site compatibility doc: https://www.fxsitecompat.com/en-CA/docs/2017/service-workers-and-push-notifications-are-disabled-on-firefox-52-esr/

	Hsin-Yi Tsai (she/her) [:hsinyi]
	Comment 2 • 7 years ago

Mark P1 as we need it now.

	Ben Kelly [:bkelly, not reviewing] Reporter
	Comment 3 • 7 years ago

Andrew, can you find someone to do this?  Probably have to fight with tests a bit.

	Andrew Overholt [:overholt]
	Comment 4 • 7 years ago

baku, can you help out here? It's pretty time-sensitive.

	Andrea Marchesini [:baku] Assignee
	Comment 5 • 7 years ago

it seems to me that SWs are disabled in ESR-52:
https://hg.mozilla.org/releases/mozilla-esr52/file/tip/modules/libpref/init/all.js#l155

	Ben Kelly [:bkelly, not reviewing] Reporter
	Comment 6 • 7 years ago

Maybe the prefs were imported from 45esr?  Do we need any prefs set for notifications?

	Andrew Overholt [:overholt]
	Comment 7 • 7 years ago

(In reply to Ben Kelly [:bkelly] from comment #6)
> Maybe the prefs were imported from 45esr?  Do we need any prefs set for
> notifications?

We don't want to turn off web notifications entirely, right? Just notifications triggered from push messages?

	Ben Kelly [:bkelly, not reviewing] Reporter
	Comment 8 • 7 years ago

Right push notifications.  I thought there was a separate flag for that, but I don't really know.

	Andrew Overholt [:overholt]
	Comment 9 • 7 years ago

Kit would know if we have a separate pref for Push that needs to be flipped for 52esr.

	Lina Butler [:lina]
	Comment 10 • 7 years ago

"dom.push.enabled", IIRC.

	Julien Cristau [:jcristau] (back April 22)
	Comment 11 • 7 years ago

(In reply to Andrea Marchesini [:baku] from comment #5)
> it seems to me that SWs are disabled in ESR-52:
> https://hg.mozilla.org/releases/mozilla-esr52/file/tip/modules/libpref/init/
> all.js#l155

browser/app/profile/firefox.js enables them, afaict.

	Julien Cristau [:jcristau] (back April 22)
	Comment 12 • 7 years ago

ESR52 goes to build on Monday, any chance we could have that patch before then?

	Andrea Marchesini [:baku] Assignee
	Comment 13 • 7 years ago

Patch written, I'm waiting to see some results on treeherder

	Cătălin Badea (:catalinb)
	Comment 15 • 7 years ago

Comment on attachment 8840488 [details] [diff] [review]
disable.patch

Review of attachment 8840488 [details] [diff] [review]:
-----------------------------------------------------------------

lgtm

	Andrea Marchesini [:baku] Assignee
	Comment 16 • 7 years ago

Comment on attachment 8840488 [details] [diff] [review]
disable.patch

We discuss this issue on dev-platform. We are going to do a big refactoring of ServiceWorker code and we cannot port it to ESR52. Better to disable SW now.

	Julien Cristau [:jcristau] (back April 22)
	Comment 17 • 7 years ago

Comment on attachment 8840488 [details] [diff] [review]
disable.patch

disable service workers and push notification for esr52

	Ryan VanderMeulen [:RyanVM]
	Comment 19 • 7 years ago
bugherder uplift

https://hg.mozilla.org/releases/mozilla-esr52/rev/470b33508a69

	Andrei Vaida [:avaida]
	Comment 20 • 7 years ago

Verified fixed on 52.0.0esr-build4 using: Windows 7 x64, Windows 10 x64, Ubuntu 16.04 x64 and macOS 10.12.3. Push and ServiceWorkers are disabled on 52esr.

	Florian Scholz (Open Web Docs)
	Comment 21 • 7 years ago

Chris Mills has updated all the compat tables for Service Workers and Push to mention this. \o/
https://developer.mozilla.org/en-US/docs/Web/API/Service_Worker_API#Browser_compatibility et al
https://developer.mozilla.org/en-US/docs/Web/API/Push_API#Browser_compatibility et al