Kelsey Gilbert [:jgilbert] Assignee
	Description • 7 years ago

      No description provided.

	Mason Chang [Inactive] [:mchang]
	Comment 3 • 7 years ago
mozreview-review

Comment on attachment 8833559 [details]
Bug 1336645 - Roll out WEBGL_debug_renderer_info to Beta and Release. -

https://reviewboard.mozilla.org/r/109782/#review110820

	Masatoshi Kimura [:emk]
	Comment 4 • 7 years ago

How privacy concerns are resolved? Or declared not resolved?

	Kelsey Gilbert [:jgilbert] Assignee
	Comment 5 • 7 years ago

(In reply to Masatoshi Kimura [:emk] from comment #4)
> How privacy concerns are resolved? Or declared not resolved?

I'm not aware of any outstanding privacy concerns here. You'll have to be more specific.

	Masatoshi Kimura [:emk]
	Comment 6 • 7 years ago

More fingerprinting vector. I'm OK if we don't care fingerprinting anymore and punting problems into "privacy.resistFingerprinting" pref. But we should not pretend as if we have no privacy issue at all.

	Kelsey Gilbert [:jgilbert] Assignee
	Comment 7 • 7 years ago

(In reply to Masatoshi Kimura [:emk] from comment #6)
> More fingerprinting vector. I'm OK if we don't care fingerprinting anymore
> and punting problems into "privacy.resistFingerprinting" pref. But we should
> not pretend as if we have no privacy issue at all.

Tracking this in bug 1337157.

	Kelsey Gilbert [:jgilbert] Assignee
	Comment 8 • 7 years ago

Comment on attachment 8833559 [details]
Bug 1336645 - Roll out WEBGL_debug_renderer_info to Beta and Release. -

Approval Request Comment
[Feature/Bug causing the regression]:
[User impact if declined]: Slow roll-out of a pref flip.
[Is this code covered by automated tests?]:
[Has the fix been verified in Nightly?]:
[Needs manual test from QE? If yes, steps to reproduce]: 
[List of other uplifts needed for the feature/fix]:
[Is the change risky?]: no
[Why is the change risky/not risky?]: It just flips a pref.
[String changes made/needed]: none

	Pulsebot
	Comment 9 • 7 years ago

Pushed by jgilbert@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/aaff9aacbf67
Roll out WEBGL_debug_renderer_info to Beta and Release. - r=mchang

	Julien Cristau [:jcristau]
	Comment 10 • 7 years ago

The uplift request doesn't explain why this should go to beta today as opposed to next cycle (when bugs 1171228/1175424 have been around for a couple of years), or why it should land without bug 1337157 :(

	Carsten Book [:Tomcat]
	Comment 11 • 7 years ago
bugherder

https://hg.mozilla.org/mozilla-central/rev/aaff9aacbf67

	Kelsey Gilbert [:jgilbert] Assignee
	Comment 12 • 7 years ago

(In reply to Julien Cristau [:jcristau] from comment #10)
> The uplift request doesn't explain why this should go to beta today as
> opposed to next cycle (when bugs 1171228/1175424 have been around for a
> couple of years), or why it should land without bug 1337157 :(

Bug 1171228 wasn't meant to leave it #ifndef RELEASE forever, and the Intent to Ship email thread exposed no blockers to implementing this. Safari also rolled this out in the mean time.

Bug 1337157 is nice-to-have, since there are already prefs to spoof and/or disable this extension. They just aren't hooked up to the central pref.

	Kelsey Gilbert [:jgilbert] Assignee
	Comment 13 • 7 years ago

Since we're shipping this in 54, and since there's no reason to not roll out this pref-only change to 53 and 52, we should just take it there too.

	Liz Henry (:lizzard) (relman/hg->git project)
	Comment 14 • 7 years ago

Comment on attachment 8833559 [details]
Bug 1336645 - Roll out WEBGL_debug_renderer_info to Beta and Release. -

Well, let's bring it to aurora at least.

	Ryan VanderMeulen [:RyanVM]
	Comment 15 • 7 years ago
bugherder uplift

https://hg.mozilla.org/releases/mozilla-aurora/rev/63752d3df9fa

	Julien Cristau [:jcristau]
	Comment 16 • 7 years ago

Comment on attachment 8833559 [details]
Bug 1336645 - Roll out WEBGL_debug_renderer_info to Beta and Release. -

Seems to me this can go in 53.

	Florian Scholz (Open Web Docs)
	Comment 17 • 7 years ago

https://developer.mozilla.org/en-US/Firefox/Releases/53#WebGL
https://developer.mozilla.org/en-US/docs/Web/API/WEBGL_debug_renderer_info