Closed Bug 1336209 Opened 7 years ago Closed 3 years ago

Clicking on links sometimes doesn't work, long-pressing results in text selection instead of context menu

Categories

(Firefox for Android Graveyard :: Toolbar, defect, P2)

Product:
Firefox for Android Graveyard
Component:
Toolbar
Version:
52 Branch
Platform:
All
Android
Type:
defect

Tracking

(fennec+, firefox52 wontfix, firefox53 wontfix, firefox54 wontfix, firefox55 wontfix, firefox56 wontfix, firefox57 wontfix)

Status:
RESOLVED INCOMPLETE
Tracking Flags:
Tracking Status
fennec + ---
firefox52 --- wontfix
firefox53 --- wontfix
firefox54 --- wontfix
firefox55 --- wontfix
firefox56 --- wontfix
firefox57 --- wontfix

People

(Reporter: kats, Unassigned)

References

Details

(Keywords: regression)

Attachments

(2 files)

bug1336209.txt
383.23 KB, text/plain
Details
Highlighting screenshot
377.85 KB, image/png
Details 
+++ This bug was initially created as a clone of Bug #1274597 +++

Same thing as bug 1274597. We fixed it once, and it's back. Reported against Aurora 52, but not yet sure which versions are affected.
If anybody happens to run into this, please do the following:
- set up the remote debugger in firefox. instructions are at https://developer.mozilla.org/en-US/docs/Tools/Remote_Debugging/Debugging_Firefox_for_Android_with_WebIDE
- connect to firefox while it's in this bad state and debug the "main process" (in WebIDE on the left side it should be listed under "Runtime apps")
- In the debugger console, run "BrowserApp.selectedBrowser". This should print out something like:
  <browser type="content" messagemanagergroup="browsers" clickthrough="never" primary="true">
In particular note whether or not you see the 'primary="true"' attribute, as that will help narrow down the problem.
Running: Firefox 53.0a2 mobile (2017-01-30)

BrowserApp.selectedBrowser
<browser type="content" messagemanagergroup="browsers" clickthrough="never">

Just the primary is missing, other than that it looks like what you predicted. The bug happens regardless of website.
Sorry for the delay. I put together a nightly build with some extra logging that should help narrow down the root of the problem. You can find the build at [1]. If you're curious about the logging you can see it in the logging patch at [2]. Please provide the logcat obtained by doing the following:
1. Install the build
2. run "adb logcat -c" to clear the log
3. run "adb logcat -v time | tee bug1336209.txt" to start logging
4. Start Fennec and reproduce the problem
5. Terminate the logging (ctrl-c to kill the command) and attach the bug1336209.txt file to the bug.

If you need help installing adb or getting a logcat please let me know. Thanks!

[1] https://queue.taskcluster.net/v1/task/LW0p2RD4TVeZC9GgrfxBFg/runs/0/artifacts/public/build/target.apk
[2] https://treeherder.mozilla.org/#/jobs?repo=try&revision=e43d9268c808044da777a53213cd2ebf7fe1beec
Flags: needinfo?(icedt)
While trying again to reproduce this bug today, I filed Bug 1338785, Bug 1338788, Bug 1338790, Bug 1338792, and Bug 1338811, seemingly all separate issues, but may or may not be related to this bug.

I will also try what's suggested above.  Thanks for continuing investigating this one.
Dropping stale needinfo, but anybody who can reproduce this please use the build I linked in comment 3 and get logging as requested. Thanks!
Flags: needinfo?(icedt)
I still have this bug but unfortunatley the li.k to your nightly build is broken. Please update the link.
Thanks for the link but my phone is an Asus Zenfone 2 (ZE551ML) and it has an x86 processor. Your Nightly build is not compiled for that architecture.
Just realized after installing that the problem is caused by the "Save Link Menus" add-on. Disabling the add-on fixed the bug. Should I contact the add-on developer or should I continue with the debugging?
(In reply to RaduM from comment #12)
> Disabling the add-on fixed the bug.

Good to know, thanks.

> Should I contact the
> add-on developer or should I continue with the debugging?

It would be helpful to me if you did the debugging steps, so I have a better idea of what's going on in this scenario. It might be that the same steps happen in other scenarios, without the add-on. If it turns out the add-on is entirely to blame, then yeah, contacting the add-on developer would be the way to go.
Attached file bug1336209.txt — 
Log file from adb and the nightly build.
Thanks! The log seems to indicate mostly normal behaviour, so I suspect the issue you're seeing is quite different from the original issue that this bug was filed for. This makes sense if the issue you're seeing is due to the add-on interfering with events. So yeah, please go ahead and contact the add-on developer if you haven't done so already.
I also got bitten by the inability to long-press links, since update to version 52. Like RaduM, I had the "Save Link Menus". Disabling the addon fix the problem.

Now it seems the problem has been reported on the addon side:

* https://addons.mozilla.org/en-US/android/addon/save-link-menus/
* https://github.com/takachanz/savelinkmenus/issues/2
I have the same problem on (my wife's) Samsung S8. Firefox doesn't allow me to click many links… The repro is very simple, I just search for something in google and in most cases I cannon tap on Images. Happens in Firefox, Firefox Beta and in Nightly :(
I am a technical person, will be very happy to debug because otherwise I will be forced to switch her to Chrome :(
One more thing: this is brand new phone, we don't have any addons.
Do you also see the problem where long-pressing on links ends up selecting text instead of showing the context menu? If not you might be seeing a different problem than what this bug is about.
Yes, I do. And it is very easy to reproduce.
Great! Can you please follow the steps in comment 1 and let me know what you see?
<browser type="content" messagemanagergroup="browsers" clickthrough="never" primary="true">
Attached image Highlighting screenshot — 
And this is how the highlighting looks like.
(In reply to Bartosz Piec from comment #22)
> <browser type="content" messagemanagergroup="browsers" clickthrough="never"
> primary="true">

Hmm, this seems to indicate it has a different root cause than the original issue this bug was filed about. I'll need to put together a build with some extra logging for you to run, I think. Are you comfortable with loading a custom Firefox build and collecting the logcat output?
(In reply to Kartikaya Gupta (email:kats@mozilla.com) from comment #24)
> Are you comfortable with loading a
> custom Firefox build and collecting the logcat output?

Absolutely.
Hm, I made a build with the click retargeting logging turned on, and then discovered that the click retargeting itself is turned off by default. Can you try going to about:config, searching for the "ui.mouse.radius.enabled" option, toggling that to true, and seeing if that helps with the behaviour you're seeing?
(In reply to Kartikaya Gupta (email:kats@mozilla.com) from comment #26)
> Hm, I made a build with the click retargeting logging turned on, and then
> discovered that the click retargeting itself is turned off by default. Can
> you try going to about:config, searching for the "ui.mouse.radius.enabled"
> option, toggling that to true, and seeing if that helps with the behaviour
> you're seeing?

I'm not the person you asked to try the config fix, but it helped me. I can't do testing with
logging, etc. since the only computer I have access to is an android tablet.
(In reply to Ken Riley from comment #27)
> I'm not the person you asked to try the config fix, but it helped me.

That's good to know, thanks!
I've found this issue on ebay.com, on Fennec 55, 56 & 57. But it's happening only on tablet devices:
-Huawei MediaPad M2 (Android 5.1.1)
-HTC Nexus 9 (Android 7.1.1)
-Xiaomi Mi Pad 2 (Android 5.1)

Steps to reproduce:
1. On ebay.com, open a category from the homepage.
2. Tap on any product image/title. 
note: Still reproducing after a force stop or clear data.
tracking-fennec: --- → ?
status-firefox56: --- → affected
status-firefox57: --- → affected
tracking-fennec: ? → +
I can reproduce this intermittently on Firefox 57/58 running on Android Oreo, Google Pixel. The Google Android team also sent us a message regarding this bug, indicating they could reproduce it on Firefox release.
status-firefox58: --- → affected
See Also: → 1550254

I have this problem on FF for Android 68.3.0
Reproduces sometimes - the same page sometimes is affected or not.
Primary affected site for me is touch.facebook.com
Setting ui.mouse.radius.enabled=true doesn't help (instantly at least, will check more).

Same problem on 68.9.0, Pixel 3A on Android 10, patched through June 5.
Setting ui.mouse.radius.enabled=true appears to have fixed it.

We have completed our launch of our new Firefox on Android. The development of the new versions use GitHub for issue tracking. If the bug report still reproduces in a current version of [Firefox on Android nightly](https://play.google.com/store/apps/details?id=org.mozilla.fenix) an issue can be reported at the [Fenix GitHub project](https://github.com/mozilla-mobile/fenix/). If you want to discuss your report please use [Mozilla's chat](https://wiki.mozilla.org/Matrix#Connect_to_Matrix) server https://chat.mozilla.org and join the [#fenix](https://chat.mozilla.org/#/room/#fenix:mozilla.org) channel.
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → INCOMPLETE
Product: Firefox for Android → Firefox for Android Graveyard
See Also: → 1809294
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: