Andreas Tolfsen ❲:ato❳ Assignee
	Description • 7 years ago

Marionette should return a ‘no such session id’ error when the Delete Session command is called and there there is no current session.

	Maja Frydrychowicz :impossibus (was :maja_zf) (needinfo me)
	Comment 14 • 7 years ago
mozreview-review

Comment on attachment 8832916 [details]
Bug 1336124 - Add assert.session for checking if session is active;

https://reviewboard.mozilla.org/r/109166/#review110786

::: testing/marionette/assert.js:39
(Diff revision 2)
> + *
> + * @throws {InvalidSessionIdError}
> + *     If |driver| does not have a session ID.
> + */
> +assert.session = function (driver, msg = "") {
> +  assert.that(sessionID => !!sessionID,

Why not just `sessionID => sessionID`?

::: testing/marionette/test_assert.js:16
(Diff revision 2)
>  
> +add_test(function test_session() {
> +  assert.session({sessionId: "foo"});
> +  Assert.throws(() => assert.session({sessionId: null}), InvalidSessionIdError);
> +  Assert.throws(() => assert.session({sessionId: undefined}), InvalidSessionIdError);
> +

Doesn't hurt to check `""`, too.

	Maja Frydrychowicz :impossibus (was :maja_zf) (needinfo me)
	Comment 15 • 7 years ago
mozreview-review

Comment on attachment 8832917 [details]
Bug 1336124 - Remove unused B2G code in session teardown;

https://reviewboard.mozilla.org/r/109168/#review110788

	Maja Frydrychowicz :impossibus (was :maja_zf) (needinfo me)
	Comment 16 • 7 years ago
mozreview-review

Comment on attachment 8832918 [details]
Bug 1336124 - Rename sessionTeardown to deleteSession;

https://reviewboard.mozilla.org/r/109170/#review110792

	Maja Frydrychowicz :impossibus (was :maja_zf) (needinfo me)
	Comment 17 • 7 years ago
mozreview-review

Comment on attachment 8832919 [details]
Bug 1336124 - Return error when there is no session;

https://reviewboard.mozilla.org/r/109172/#review110798

	Maja Frydrychowicz :impossibus (was :maja_zf) (needinfo me)
	Comment 18 • 7 years ago
mozreview-review

Comment on attachment 8833340 [details]
Bug 1336124 - Only delete session if one exists when testing capabilities;

https://reviewboard.mozilla.org/r/109598/#review110800

	Andreas Tolfsen ❲:ato❳ Assignee
	Comment 19 • 7 years ago
mozreview-review-reply

Comment on attachment 8832916 [details]
Bug 1336124 - Add assert.session for checking if session is active;

https://reviewboard.mozilla.org/r/109166/#review110786

> Why not just `sessionID => sessionID`?

Good point.

> Doesn't hurt to check `""`, too.

Indeed.

	Pulsebot
	Comment 25 • 7 years ago

Pushed by atolfsen@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/589a01fb4790
Add assert.session for checking if session is active; r=maja_zf
https://hg.mozilla.org/integration/autoland/rev/c93a410adde0
Remove unused B2G code in session teardown; r=maja_zf
https://hg.mozilla.org/integration/autoland/rev/ca0345ae33a4
Rename sessionTeardown to deleteSession; r=maja_zf
https://hg.mozilla.org/integration/autoland/rev/6d17a85df7e3
Return error when there is no session; r=maja_zf
https://hg.mozilla.org/integration/autoland/rev/c4441c1492fd
Only delete session if one exists when testing capabilities; r=maja_zf

	Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)
	Comment 26 • 7 years ago
bugherder

https://hg.mozilla.org/mozilla-central/rev/589a01fb4790
https://hg.mozilla.org/mozilla-central/rev/c93a410adde0
https://hg.mozilla.org/mozilla-central/rev/ca0345ae33a4
https://hg.mozilla.org/mozilla-central/rev/6d17a85df7e3
https://hg.mozilla.org/mozilla-central/rev/c4441c1492fd

	Andreas Tolfsen ❲:ato❳ Assignee
	Comment 27 • 7 years ago

Sheriffs: Please uplift to Aurora and Beta as testonly.

	Ryan VanderMeulen [:RyanVM]
	Comment 28 • 7 years ago
bugherder uplift

https://hg.mozilla.org/releases/mozilla-aurora/rev/73551688c6ac
https://hg.mozilla.org/releases/mozilla-aurora/rev/8ab5323b26bd
https://hg.mozilla.org/releases/mozilla-aurora/rev/e007ff236f9a
https://hg.mozilla.org/releases/mozilla-aurora/rev/14f3c33992ba
https://hg.mozilla.org/releases/mozilla-aurora/rev/c758a3871aaa

	Ryan VanderMeulen [:RyanVM]
	Comment 29 • 7 years ago
bugherder uplift

https://hg.mozilla.org/releases/mozilla-beta/rev/19f821a6588c
https://hg.mozilla.org/releases/mozilla-beta/rev/df9b8deb4594
https://hg.mozilla.org/releases/mozilla-beta/rev/246c07f0bf7d
https://hg.mozilla.org/releases/mozilla-beta/rev/4333619aa67d
https://hg.mozilla.org/releases/mozilla-beta/rev/9ee72b7bb804