Paul Adenot (:padenot) Assignee
	Description • 7 years ago

This has changed at some point in the spec, and we haven't done the change.

	Andreas Pehrson [:pehrsons]
	Comment 2 • 7 years ago

Comment on attachment 8832876 [details] [diff] [review]
fix it and add a test

Review of attachment 8832876 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/media/webaudio/test/test_analyserNodeMinimum.html
@@ +30,5 @@
> +  sp.onaudioprocess = function() {
> +    analyser.getFloatFrequencyData(buf);
> +    var correct = true;
> +    for (var i = 0; i < buf.length; i++) {
> +     correct |= buf[i] == -Infinity;

This should be &=.

@@ +33,5 @@
> +    for (var i = 0; i < buf.length; i++) {
> +     correct |= buf[i] == -Infinity;
> +    }
> +    ok(correct, "silent input process -Infinity in decibel bins");
> +    if(iteration_count--) {

And this should be negated.

	Pulsebot
	Comment 3 • 7 years ago

Pushed by paul@paul.cx:
https://hg.mozilla.org/integration/mozilla-inbound/rev/02e6983ec02a
When the input is silent, AnalyserNode.getFloatFrequencyData should put -Infinity in the buffer. r=pehrsons

	Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)
	Comment 4 • 7 years ago
bugherder

https://hg.mozilla.org/mozilla-central/rev/02e6983ec02a

	Eric Shepherd [:sheppy]
	Comment 5 • 7 years ago

Updated documentation:

https://developer.mozilla.org/en-US/docs/Web/API/AnalyserNode/getFloatFrequencyData

https://developer.mozilla.org/en-US/Firefox/Releases/54