Andreas Tolfsen ❲:ato❳ Reporter
	Description • 7 years ago

There is no provision in WebDriver that allows you to set the session ID when making a new session.  Marionette allows one to pass a `sessionId` parameter in as part of the capabilities dictionary (although not as part of `desiredCapabilities` or `requiredCapabilities`) to override the randomly generate UUID.

A new session is a new session and should come with a new UUID.  We should avoid overriding the session ID when calling restart().

(Spawned from discussion in https://reviewboard.mozilla.org/r/106824/#review107962.)

	Henrik Skupin [:whimboo][⌚️UTC+1]
	Comment 1 • 7 years ago

All the set capabilities for a restart test should be retained after the restart of Firefox. I assume what we would have to do here is to store the original desired/required capabilities and make use of them when calling start_session() from within restart()? Currently I also don't see that we keep them, by pushing in the former session id.

	Andreas Tolfsen ❲:ato❳ Reporter
	Comment 2 • 7 years ago

So as far as I can tell, restart() is not a Marionette command, but implemented entirely in the client?  I think the idea that state should be maintained internally in the server across sessions is wrong, so if restarting Firefox expects the same capabilities as before to apply to the new session it should pass these in when starting the next session.

Does that match your thinking?

	Henrik Skupin [:whimboo][⌚️UTC+1]
	Comment 3 • 7 years ago

I didn't say that the server should keep the state, that's not working due to the restart. But the client should make sure to transparently pass the capabilities over to the next session. I don't see why tests would have to start a new session.

	Andreas Tolfsen ❲:ato❳ Reporter
	Comment 4 • 7 years ago

Yes, I think we’re aligned.

Some tests have to start a new session to test features like capabilities processing, that the timeout durations work, and accessibility, which is not enabled by default.

	David Burns :automatedtester
	Comment 5 • 7 years ago

I've had a brief look and looks like we have removed this already, can you just double check for me please? If it is gone please close this bug.

	Andreas Tolfsen ❲:ato❳ Reporter
	Comment 6 • 7 years ago

(In reply to David Burns :automatedtester from comment #5)
> I've had a brief look and looks like we have removed this already, can you
> just double check for me please? If it is gone please close this bug.

We have!  Thanks for triaging.