Closed
Bug 1331305
Opened 8 years ago
Closed 7 years ago
Auto resize the height of textarea of "add comment"
Categories
(bugzilla.mozilla.org :: User Interface, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: kuoe0.tw, Unassigned)
References
Details
Attachments
(1 file, 1 obsolete file)
I think it would be a better experience when the height of the textarea of "add comment" would be resized automatically. I think it is a bad experience when we type a long comment and we have to scroll the little textarea to check it. And the height of "preview" should be "auto", too. It makes the comment editor can preview his/her entire comment quickly.
Reporter | ||
Updated•8 years ago
|
Assignee: ui → nobody
Component: User Interface → User Interface: Modal
Product: Bugzilla → bugzilla.mozilla.org
QA Contact: default-qa
Version: 5.1.1 → Production
Reporter | ||
Updated•8 years ago
|
Assignee: nobody → kuoe0
Reporter | ||
Comment 1•8 years ago
|
||
I created a patch to make the comment textarea be resized automatically.
Attachment #8827765 -
Flags: feedback?(dkl)
Comment 2•7 years ago
|
||
I'm going to +1 this, I frequently find the textarea to be too small when I'm editing anything but a very short comment. I think we might want to set some kind of upper limit on its size (I also commented to this effect on the PR)
Comment 3•7 years ago
|
||
Comment on attachment 8827765 [details] [review] github pull request Add a max height and I think this is a useful change.
Attachment #8827765 -
Flags: feedback?(dkl) → feedback-
Reporter | ||
Comment 4•7 years ago
|
||
I updated the patch with setting 80% height of the viewport as the max height.
Updated•7 years ago
|
Attachment #8827765 -
Flags: review?(dylan)
Comment 5•7 years ago
|
||
Comment on attachment 8827765 [details] [review] github pull request For every character I add or remove the height of the comment box grows! Here is a short video of what I saw: https://www.youtube.com/watch?v=2Qs_Wd7ezSk
Attachment #8827765 -
Flags: review?(dylan)
Attachment #8827765 -
Flags: review-
Attachment #8827765 -
Flags: feedback-
Comment 6•7 years ago
|
||
This finally annoyed me enough that I created an updated PR using the autosizer library. :)
Assignee: kuoe0 → wlachance
Attachment #8827765 -
Attachment is obsolete: true
Attachment #8884864 -
Flags: review?(dylan)
Comment 7•7 years ago
|
||
Comment on attachment 8884864 [details] [review] PR using autosizer library r-, per github comments: Is there a way of making it readjust the size when the textarea changes? Currently if you reply to a long comment the box will not resize until you type stuff. If that can't be fixed, let me know and I'll approve as is.
Attachment #8884864 -
Flags: review?(dylan) → review-
Comment 8•7 years ago
|
||
Comment on attachment 8884864 [details] [review] PR using autosizer library PR updated
Attachment #8884864 -
Flags: review- → review?(dylan)
Updated•7 years ago
|
Attachment #8884864 -
Flags: review?(dylan) → review+
Updated•7 years ago
|
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Updated•5 years ago
|
Assignee: wlachance → nobody
Component: User Interface: Modal → User Interface
You need to log in
before you can comment on or make changes to this bug.
Description
•