[wdspec] Add tests for parsing of actions messages
Categories
(Remote Protocol :: Marionette, defect, P1)
Tracking
(firefox116 fixed)
Tracking | Status | |
---|---|---|
firefox116 | --- | fixed |
People
(Reporter: impossibus, Assigned: whimboo)
References
(Blocks 2 open bugs)
Details
(Whiteboard: [webdriver:m7], [wptsync upstream])
Attachments
(2 files)
Similar in spirit to https://dxr.mozilla.org/mozilla-central/rev/2977ca1224525680cbfb5c3ce3018818b6dfd8f2/testing/marionette/test_action.js
Comment 1•7 years ago
|
||
maja_zf: Has this been done now? I remember reviewing WPT action tests.
Reporter | ||
Comment 2•7 years ago
|
||
This bug is about tests that check the format of the json payload of the command, invalid requests, etc. There are xpcshell tests like that in test_action.js, but none in wpt. The wpt actions tests you reviewed mostly check the events synthesized by commands.
Updated•7 years ago
|
Updated•6 years ago
|
Updated•6 years ago
|
Assignee | ||
Updated•6 years ago
|
Updated•2 years ago
|
Assignee | ||
Updated•1 year ago
|
Assignee | ||
Comment 3•1 year ago
|
||
Bringing this up for triage given that for element interaction in BiDi we want to re-use the action implementation from classic (bug 1792090) and would require such tests. We could certainly add BiDi tests first on a different bug and come back to that one afterward.
Assignee | ||
Comment 4•1 year ago
|
||
We will pick this bug up after bug 1792090 has been landed and will create tests for BiDi as well as classic given that the assertions won't be different. Given that our focus is on BiDi lets move it to its component.
Assignee | ||
Comment 5•1 year ago
|
||
Actually other implementations might not share the same code and as such it will be better to have the same tests for both protocols. As such lets move this one back to Marionette and create a new WebDriver BiDi specific bug.
Assignee | ||
Updated•1 year ago
|
Assignee | ||
Updated•1 year ago
|
Updated•1 year ago
|
Assignee | ||
Updated•1 year ago
|
Assignee | ||
Updated•10 months ago
|
Assignee | ||
Comment 6•10 months ago
|
||
Pushed by hskupin@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/bde95b6dffb0 [wdspec] Add tests for parsing of actions messages. r=webdriver-reviewers,jdescottes
Comment 8•10 months ago
|
||
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/40837 for changes under testing/web-platform/tests
Updated•10 months ago
|
Comment 9•10 months ago
|
||
bugherder |
Comment 10•10 months ago
|
||
Upstream PR was closed without merging
Assignee | ||
Comment 11•10 months ago
|
||
Comment 12•10 months ago
|
||
Pushed by hskupin@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/b5f7e8f33e3a [wdspec] Extend timeout for classic/perform_actions/invalid.py.
Comment 13•10 months ago
|
||
A patch has been attached on this bug, which was already closed. Filing a separate bug will ensure better tracking. If this was not by mistake and further action is needed, please alert the appropriate party. (Or: if the patch doesn't change behavior -- e.g. landing a test case, or fixing a typo -- then feel free to disregard this message)
Comment 14•10 months ago
|
||
bugherder |
Comment 15•10 months ago
|
||
Upstream PR merged by jgraham
Description
•