Jonathan Claudius [:claudijd] (use NEEDINFO) Reporter
	Description • 7 years ago

I'd like to report two bugs in the project review form that triggers relevant Legal/Finance/Security bugs for review.

1.) The RRA (Security) bugs we're creating have an extra string on them "Legal Review: ", which is causing subjects like this "RRA: Legal Review: Contract for Engaging an individual (independent contractor, temp agency worker, incorporated) with Imanol Fernández Gorostizaga" to be created.  Ideally, if this was a valid security bug, it would look like this "RRA: Contract for Engaging an individual (independent contractor, temp agency worker, incorporated) with Imanol Fernández Gorostizaga"

2.) In the bug form the user is prompted for an answer to "What are you doing?" and they can select from a drop down list.  In that list there is "Engaging and individual..." that when selected should not create an RRA bug.  This behavior was requested in bug 1264821 in comment 32 (https://bugzilla.mozilla.org/show_bug.cgi?id=1264821#c32)

	David Lawrence [:dkl] Assignee
	Comment 1 • 7 years ago

To https://github.com/mozilla-bteam/bmo.git
   e3f7a84..840bbad  master -> master

	David Lawrence [:dkl] Assignee
	Comment 2 • 7 years ago

This is live now. It also fixes the issue of "Legal Review" being included in the Finance bug as well.

	Jonathan Claudius [:claudijd] (use NEEDINFO) Reporter
	Comment 3 • 7 years ago

dkl: thank you!

	Jonathan Claudius [:claudijd] (use NEEDINFO) Reporter
	Comment 4 • 7 years ago

Reopening this bug, because it seems #2 in the original request is not actually fixed.  Repasting the issue to make it clear...

2.) In the bug form the user is prompted for an answer to "What are you doing?" and they can select from a drop down list.  In that list there is "Engaging and individual..." that when selected should not create an RRA bug.  This behavior was requested in bug 1264821 in comment 32 (https://bugzilla.mozilla.org/show_bug.cgi?id=1264821#c32)

dkl: could you have a look?

	David Lawrence [:dkl] Assignee
	Comment 5 • 7 years ago

Looking

	David Lawrence [:dkl] Assignee
	Comment 6 • 7 years ago

(In reply to Jonathan Claudius [:claudijd] (use NEEDINFO) from comment #4)
> Reopening this bug, because it seems #2 in the original request is not
> actually fixed.  Repasting the issue to make it clear...
> 
> 2.) In the bug form the user is prompted for an answer to "What are you
> doing?" and they can select from a drop down list.  In that list there is
> "Engaging and individual..." that when selected should not create an RRA
> bug.  This behavior was requested in bug 1264821 in comment 32
> (https://bugzilla.mozilla.org/show_bug.cgi?id=1264821#c32)
> 
> dkl: could you have a look?

Hmm from looking at the code, this should not be happening. Can I see the recent bug where this was created and it should not have?

Thanks
dkl

	Jonathan Claudius [:claudijd] (use NEEDINFO) Reporter
	Comment 7 • 7 years ago

:dkl - bug 1339598 is an example of the behavior I'm referring to

	David Lawrence [:dkl] Assignee
	Comment 8 • 7 years ago

(In reply to Jonathan Claudius [:claudijd] (use NEEDINFO) from comment #7)
> :dkl - bug 1339598 is an example of the behavior I'm referring to

Ah I see what it is now. Basically I also file a RRA if the user selects one of the specified contract types OR selects 'Data Access' == Yes. So in the case of bug 1339598, the user selected Yes. Is this no longer needed? I can remove that particular check from the RRA criteria.

dkl

	Jonathan Claudius [:claudijd] (use NEEDINFO) Reporter
	Comment 9 • 7 years ago

that makes more sense, thanks for hunting that down.  My preference would be that "Data Access" have no bearing on whether an RRA is created or not.

	David Lawrence [:dkl] Assignee
	Comment 10 • 6 years ago

(In reply to Jonathan Claudius [:claudijd] (use NEEDINFO) from comment #9)
> that makes more sense, thanks for hunting that down.  My preference would be
> that "Data Access" have no bearing on whether an RRA is created or not.

Merged to master. Will be in the next deployment.