Ralph Giles (:rillian) Assignee
	Description • 8 years ago

Ben Kelly reported the following failure with ./mach bootstrap installing rust:

URLError: <urlopen error [Errno 1] _ssl.c:510: error:14077410:SSL routines:SSL23_GET_SERVER_HELLO:sslv3 alert handshake failure>

It seems that older Python 2.7.6 urllib2 doesn't support SNI. I thought using the in-tree `requests` module would work around this, but apparently not.

	Nathan Froyd [:froydnj]
	Comment 2 • 8 years ago
mozreview-review

Comment on attachment 8819351 [details]
Bug 1324040 - mozboot: Download rustup without SNI.

https://reviewboard.mozilla.org/r/99172/#review99462

::: python/mozboot/mozboot/rust.py:15
(Diff revision 1)
> -RUSTUP_URL_BASE = 'https://static.rust-lang.org/rustup'
> +# Use the no-CNAME host for compatibilty with Python 2.7
> +# which doesn't support SNI.
> +RUSTUP_URL_BASE = 'https://static-rust-lang-org.s3.amazonaws.com/rustup'

Nit: maybe "...doesn't support TLS SNI" so that people have an easier time figuring out (i.e. googling/yahooing) what's going on?  I'm not going to insist on this, though.

	Pulsebot
	Comment 3 • 8 years ago

Pushed by rgiles@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/f1d3e2d6c2b8
mozboot: Download rustup without SNI. r=froydnj

	Simon Sapin (:SimonSapin)
	Comment 4 • 8 years ago

For what it’s worth, Python 2.7.9 (released on 2014-12-10) and later support SNI natively.

There’s also a way to make Requests send SNI on older Python, but that requires enough dependency that it’s probably not very helpful for the purpose of `./mach bootstrap`:

https://stackoverflow.com/questions/18578439/using-requests-with-tls-doesnt-give-sni-support/18579484#18579484

	Ralph Giles (:rillian) Assignee
	Comment 5 • 8 years ago

Good to know. I think this is a better fix than adding the required dependencies.

	Phil Ringnalda (:philor)
	Comment 6 • 8 years ago
bugherder

https://hg.mozilla.org/mozilla-central/rev/f1d3e2d6c2b8