Jan-Ivar Bruaroey [:jib] (needinfo? me) Assignee
	Description • 8 years ago

After bug 1263312 we currently have:

interface RTCIceCandidate {
  attribute DOMString       candidate;
  attribute DOMString?      sdpMid;
  attribute unsigned short? sdpMLineIndex;

  jsonifier;
};

and the spec demands:

[Constructor(RTCIceCandidateInit candidateInitDict)]
interface RTCIceCandidate {
    readonly attribute DOMString               candidate;
    readonly attribute DOMString?              sdpMid;
    readonly attribute unsigned short?         sdpMLineIndex;
    readonly attribute DOMString               foundation;
    readonly attribute unsigned long           priority;
    readonly attribute DOMString               ip;
    readonly attribute RTCIceProtocol          protocol;
    readonly attribute unsigned short          port;
    readonly attribute RTCIceCandidateType     type;
    readonly attribute RTCIceTcpCandidateType? tcpType;
    readonly attribute DOMString?              relatedAddress;
    readonly attribute unsigned short?         relatedPort;
    serializer = {candidate, sdpMid, sdpMLineIndex};
};

The biggest problem here is probably the serializer, which only specifies that three of the attributes should be enumerated. I don't think our jsonifier syntax supports this, so this is probably blocking on bug 863402.

	Nils Ohlmeier [:drno]
	Comment 1 • 7 years ago

The most recent editor draft version still contains this syntax is:

[Constructor(optional RTCIceCandidateInit candidateInitDict)]
interface RTCIceCandidate {
    readonly attribute DOMString               candidate;
    readonly attribute DOMString?              sdpMid;
    readonly attribute unsigned short?         sdpMLineIndex;
    readonly attribute DOMString?              foundation;
    readonly attribute RTCIceComponent?        component;
    readonly attribute unsigned long?          priority;
    readonly attribute DOMString?              ip;
    readonly attribute RTCIceProtocol?         protocol;
    readonly attribute unsigned short?         port;
    readonly attribute RTCIceCandidateType?    type;
    readonly attribute RTCIceTcpCandidateType? tcpType;
    readonly attribute DOMString?              relatedAddress;
    readonly attribute unsigned short?         relatedPort;
    readonly attribute DOMString?              ufrag;
    serializer = {candidate, sdpMid, sdpMLineIndex, ufrag};
};

But there is a issue open to replace serializer with toJSON https://github.com/w3c/webrtc-pc/issues/1419 for which this PR exists https://github.com/w3c/webrtc-pc/pull/1449

	Bulk Bug Changes for mreavy's org
	Comment 2 • 7 years ago

Mass change P2->P3 to align with new Mozilla triage process.

	Boris Zbarsky [:bzbarsky]
	Comment 3 • 6 years ago

There is no more jsonifier.  You can either do a toJSON with default behavior or write a custom one, however you prefer.

	Pulsebot
	Comment 7 • 2 months ago

Pushed by jbruaroey@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/1957e76267e3
Make RTCIceCandidate members readonly and add members parsed from candidate string. r=bwc,webidl,smaug