Closed Bug 1314959 Opened 8 years ago Closed 7 years ago

Turn on pref for requestIdleCallback

Categories

(Core :: DOM: Core & HTML, defect)

48 Branch
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla55
Tracking Status
firefox55 --- fixed

People

(Reporter: farre, Assigned: farre)

References

Details

(Keywords: dev-doc-complete)

Attachments

(1 file)

      No description provided.
Depends on: 1314314
Assignee: nobody → afarre
Depends on: 1313864
Blocks: 1317743
Blocks: 1329077
Bug 1315260, Bug 1313989, Bug 1313864 have all been fixed, which was what was stopping us from shipping requestIdleCallback.

Bug 1318720 is still remaining, but I'm not sure how important that is to fix that before shipping requestIdleCallback.

Any thoughts Ben?
Flags: needinfo?(bkelly)
Attachment #8840463 - Flags: review?(bugs)
(In reply to Andreas Farre [:farre] from comment #1)
> Bug 1318720 is still remaining, but I'm not sure how important that is to
> fix that before shipping requestIdleCallback.

This is a compat issue, but we could still probably ship as long as we fix it soonish.  IMO anyway.
Flags: needinfo?(bkelly)
Bug 1318720 feels like reasonable important since it is a spec violation and other browsers don't behave that way (IIRC).
Is Bug 1318720 somehow hard to implement? In my mind it feels rather simple. One could for example mark requests with some generation and not ever execute requests which has higher generation than the current one.
Comment on attachment 8840463 [details] [diff] [review]
0001-Bug-1314959-Enable-requestIdleCallback-by-default.-r.patch

I think I'd like to see the previous comment answered and Bug 1318720 possibly fixed before reviewing this.
Flags: needinfo?(afarre)
Attachment #8840463 - Flags: review?(bugs)
(In reply to Olli Pettay [:smaug] (pto-ish for couple of days) from comment #4)
> Is Bug 1318720 somehow hard to implement? In my mind it feels rather simple.
> One could for example mark requests with some generation and not ever
> execute requests which has higher generation than the current one.

I'm going to set a "chaining limit", based on the id generator in nsGlobalWindow, in the executor and only allow requests with lower id to be executed. And whenever execution/idle dispatch stops due to that I'll set a timeout handler to the deadline of the last idle period to start dispatching again. So no, not that hard.
Flags: needinfo?(afarre)
Seems like we'll block on bug 1318720 here so setting dependency.
Depends on: 1318720
Pushed by afarre@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/3ec06476d730
Enable requestIdleCallback by default. r=smaug
https://hg.mozilla.org/mozilla-central/rev/3ec06476d730
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
Are we considering uplifting this to 54?
Flags: needinfo?(afarre)
I would really want to say yes to this, but that means that uplifting bug 1318720 as well.

Hmm, I thought that there was more. Ok, that might actually be doable.
Flags: needinfo?(afarre)
I'll leave it up to you but if we're confident enough to turn this on in 54 I'm happy to hear it.
Flags: needinfo?(afarre)
Decided to not uplift, forgot to clear needinfo.
Flags: needinfo?(afarre)
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: