Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout) Reporter
	Description • 8 years ago

B2G-related code gets removed from mozilla-central, see bug 1306391.

	Masayuki Nakano [:masayuki] (he/him)(JST, +0900)
	Comment 1 • 7 years ago

mds:

Are you working on this? If no, I'd like to do this because fixing this bug makes patches for my P1 bug simpler. So, if you need more time to remove it, I'd like to do this.

	Michelangelo De Simone [Offline] [:mds] Assignee
	Comment 2 • 7 years ago

(In reply to Masayuki Nakano [:masayuki] (Mozilla Japan) from comment #1)

> Are you working on this? If no, I'd like to do this because fixing this bug
> makes patches for my P1 bug simpler. So, if you need more time to remove it,
> I'd like to do this.

I'm waiting for another couple of patches to land then I'll move to this (probably a couple of days).
Of course, if it's urgent I'm totally in for you to take it off my table.:-)

	Masayuki Nakano [:masayuki] (he/him)(JST, +0900)
	Comment 3 • 7 years ago

Okay, no problem. My bug 1322736 will remove before/after keyboard events. So, it may conflict with your patch at PresShell, be careful.

	Masayuki Nakano [:masayuki] (he/him)(JST, +0900)
	Comment 5 • 7 years ago

You should remove following code too:
PresShell::IsTargetIframe()
PresShell::HandleKeyboardEvent() (needs to change the caller, PresShell::DispatchEventToDOM())
PresShell::ForwardKeyToInputMethodApp()
PresShell::ForwardKeyToInputMethodAppOrDispatch()
nsIPresShell::mHardwareKeyHandler
nsIHardwareKeyHandler related code in nsLayoutModule.cpp

	(no longer active)
	Comment 6 • 7 years ago
mozreview-review

Comment on attachment 8820941 [details]
Bug 1313169 - Remove dom/inputmethod/ and related code.

https://reviewboard.mozilla.org/r/100332/#review101116

Thanks, looks good!  But please file a follow-up for comment 5 too.

	Michelangelo De Simone [Offline] [:mds] Assignee
	Comment 8 • 7 years ago

(In reply to Masayuki Nakano [:masayuki] (Mozilla Japan) from comment #5)

> You should remove following code too:
> ...snip...

Thanks!

	Pulsebot
	Comment 9 • 7 years ago

Pushed by mdesimone@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/d116e76778e6
Remove dom/inputmethod/ and related code. r=Ehsan

	Phil Ringnalda (:philor)
	Comment 10 • 7 years ago
bugherder

https://hg.mozilla.org/mozilla-central/rev/d116e76778e6

	Chris Mills [:cmills]
	Comment 11 • 7 years ago

Adding ddn, just to check the docs for this.

	Chris Mills [:cmills]
	Comment 12 • 7 years ago

I've checked this out; we never documented InputMethod, and I've deleted the setInputMethodActive() method page and added a note to the Fx53 rel notes:

https://developer.mozilla.org/en-US/docs/Web/API/HTMLIFrameElement
https://developer.mozilla.org/en-US/docs/Web/API/HTMLIFrameElement/setInputMethodActive
https://developer.mozilla.org/en-US/Firefox/Releases/53

Let me know if that looks OK. Thanks!