Tom S [:evilpie] Assignee
	Description • 8 years ago

Another "generic" function that was added to the constructor. I think this method is relatively unknown, because it's not documented on MDN and almost nobody really needs to work on ArrayBuffers.

We should land a warning in this cycle and then remove it in the next cycle.

	Lars T Hansen [:lth]
	Comment 1 • 8 years ago

Jukka, are you using this?  I ask because you made some noises about SharedArrayBuffer's slice (though that could have been the instance method, not the static method).

	Jukka Jylänki
	Comment 2 • 8 years ago

(In reply to Tom Schuster [:evilpie] from comment #0)
> Another "generic" function that was added to the constructor. I think this
> method is relatively unknown, because it's not documented on MDN and almost
> nobody really needs to work on ArrayBuffers.
> 
> We should land a warning in this cycle and then remove it in the next cycle.

Is this the function that is being removed? https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/ArrayBuffer/slice . It is documented on MDN. Why would we remove that, it seems like an useful functionality?

(In reply to Lars T Hansen [:lth] from comment #1)
> Jukka, are you using this?  I ask because you made some noises about
> SharedArrayBuffer's slice (though that could have been the instance method,
> not the static method).

We are using that, and have a polyfill to add SharedArrayBuffer.slice() as well. I don't know off the top of my head though what the extent of our usage of that is, and if we could remove all uses. However, it's an useful function, I don't think we should remove that? (What's the alternative code form?) Since it is documented, we should also modify the documentation page to show that it's deprecated and point to the alternative code paths. Also, is there a standards body discussion about this somewhere?

(Or perhaps I missed the point altogether, and it's about some other function signature and not the exact one I linked to?)

	Tooru Fujisawa [:arai]
	Comment 3 • 8 years ago

It's not about prototype's property that's in the MDN page, but constructor's property.
so, literally "ArrayBuffer.slice".

	Lars T Hansen [:lth]
	Comment 4 • 8 years ago

Yes, importantly:

ArrayBuffer.prototype.slice is in Ecma262
SharedArrayBuffer.prototype.slice is in the SAB+Atomics proposal (and now in Firefox)

ArrayBuffer.slice is a Firefox-only static method with a different signature; a dead-end feature
There is no SharedArrayBuffer.slice

	Jukka Jylänki
	Comment 5 • 8 years ago

Thanks, that makes sense. Yeah, we don't use ArrayBuffer.slice(myBuffer, ...), but only myBuffer.slice(...), so removing the static version sounds ok to me.

	Tom S [:evilpie] Assignee
	Comment 6 • 8 years ago

The warning patch landed in 52, should we risk removing this in 53?

	Kohei Yoshino [:kohei]
	Comment 7 • 8 years ago

Posted the site compatibility doc: https://www.fxsitecompat.com/en-CA/docs/2016/arraybuffer-slice-will-be-removed/

	Tom S [:evilpie] Assignee
	Comment 8 • 8 years ago

I haven't actually tested this, because of my laptop situation, but I am pretty optimistic this will work.

	Tooru Fujisawa [:arai]
	Comment 9 • 8 years ago

Comment on attachment 8817697 [details] [diff] [review]
Remove non-standard static ArrayBuffers.slice (not ArrayBuffer.prototype.slice)

Review of attachment 8817697 [details] [diff] [review]:
-----------------------------------------------------------------

looks good :)

	Pulsebot
	Comment 10 • 8 years ago

Pushed by evilpies@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/26d101a9edac
Remove non-standard static ArrayBuffers.slice. r=arai

	Phil Ringnalda (:philor)
	Comment 11 • 8 years ago
bugherder

https://hg.mozilla.org/mozilla-central/rev/26d101a9edac

	Sebastian Zartner [:sebo]
	Comment 12 • 7 years ago

Documented it at https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/ArrayBuffer#Methods_2 and added the related compatibility information. And also added a release note at https://developer.mozilla.org/en-US/Firefox/Releases/53#JavaScript.

Sebastian