Xidorn Quan [:xidorn] UTC+11 Reporter
	Description • 8 years ago

CSS Variables has been enabled since Firefox 31. We should remove this pref.

Even if we do not remove it, it would not control CSS Variables in stylo.

	Julien Cristau [:jcristau]
	Comment 1 • 7 years ago

Mass wontfix for bugs affecting firefox 52.

	Ting-Yu Lin [:TYLin] (PDT, UTC-7) Assignee
	Comment 3 • 7 years ago

https://treeherder.mozilla.org/#/jobs?repo=try&revision=de0d49348d5686020d0931459d822a1a0870c07d

	Xidorn Quan [:xidorn] UTC+11 Reporter
	Comment 4 • 7 years ago
mozreview-review

Comment on attachment 8855594 [details]
Bug 1312328 - Remove CSS variables preference "layout.css.variables.enabled".

https://reviewboard.mozilla.org/r/127448/#review130164

Looks good, thanks.

	Pulsebot
	Comment 5 • 7 years ago

Pushed by tlin@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/07435005e74a
Remove CSS variables preference "layout.css.variables.enabled". r=xidorn

	Carsten Book [:Tomcat]
	Comment 6 • 7 years ago
bugherder

https://hg.mozilla.org/mozilla-central/rev/07435005e74a

	Carsten Book [:Tomcat]
	Comment 7 • 7 years ago
bugherder

https://hg.mozilla.org/mozilla-central/rev/07435005e74a

	Chris Mills [:cmills]
	Comment 9 • 7 years ago

I've added a note to the relevant browser compat info about this
https://developer.mozilla.org/en-US/docs/Web/CSS/Using_CSS_variables#Browser_compatibility
https://developer.mozilla.org/en-US/docs/Web/CSS/var#Browser_compatibility

I've also added a note to the Fx55 rel notes:
https://developer.mozilla.org/en-US/Firefox/Releases/55#CSS

Let me know if you think that covers it, or if anything else is needed. thanks!

	Ting-Yu Lin [:TYLin] (PDT, UTC-7) Assignee
	Comment 10 • 7 years ago

Chris, the documentation changes look good to me. Thanks.