Marcos Caceres [:marcosc] Assignee
	Description • 8 years ago

To avoid confusion with service worker's install event, the Web Manifest's "install" event got renamed to "appinstalled".

	Marcos Caceres [:marcosc] Assignee
	Comment 1 • 8 years ago

This is literally just a rename of an event from "install" to "onappinstalled".

Sorry qDot - word's most boring review... thought hopefully quick.

	Marcos Caceres [:marcosc] Assignee
	Comment 2 • 8 years ago

https://treeherder.mozilla.org/#/jobs?repo=try&revision=2ecdf276dcc9

	Carsten Book [:Tomcat]
	Comment 4 • 8 years ago

need dom peer review for the change in dom/webidl/Window.webidl

	Marcos Caceres [:marcosc] Assignee
	Comment 5 • 8 years ago

I think qDot is a DOM peer. See: https://twitter.com/qDot/status/783406299992031232

Maybe he didn't click the right buttons somewhere?

	Carsten Book [:Tomcat]
	Comment 6 • 8 years ago

Kyle, can you file a bug to update http://hg.mozilla.org/hgcustom/version-control-tools/file/tip/hghooks/mozhghooks/prevent_webidl_changes.py ?

	Marcos Caceres [:marcosc] Assignee
	Comment 7 • 8 years ago

Carsten, sorry... unrelated (kinda), but there are a lot of names in that list of people who no longer work at Mozilla. Does that matter?

	Carsten Book [:Tomcat]
	Comment 8 • 8 years ago

(In reply to Marcos Caceres [:marcosc] from comment #7)
> Carsten, sorry... unrelated (kinda), but there are a lot of names in that
> list of people who no longer work at Mozilla. Does that matter?

i think that it does not depend on a employment status to be dom peer (also this would exclude per default community) and so a non-employee can be dom-peer - only if someone decide that if someone leave he/she would have no time to be dom peer anymore someone can resign from this role.

	Marcos Caceres [:marcosc] Assignee
	Comment 9 • 8 years ago

(In reply to Carsten Book [:Tomcat] from comment #8)
> i think that it does not depend on a employment status to be dom peer (also
> this would exclude per default community) and so a non-employee can be
> dom-peer - only if someone decide that if someone leave he/she would have no
> time to be dom peer anymore someone can resign from this role.

Make sense. Thanks!

	Kyle Machulis [:qdot] [:kmachulis] (INACTIVE)
	Comment 10 • 8 years ago

Bug 1309644 filed. I'll land this once that's and deployed.

	Pulsebot
	Comment 11 • 8 years ago

Pushed by kmachulis@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/72ecc0c64b13
Web manifest's window.oninstall renamed onappinstalled. r=qdot

	Kyle Machulis [:qdot] [:kmachulis] (INACTIVE)
	Comment 12 • 8 years ago

Ok, bug 1309644 resolved, pushed this patch cleanly with me as a reviewer and peer now.

	Carsten Book [:Tomcat]
	Comment 13 • 8 years ago
bugherder

https://hg.mozilla.org/mozilla-central/rev/72ecc0c64b13

	Chris Mills [:cmills]
	Comment 14 • 7 years ago

I see the docs have mostly been done already (thanks Marcos!); I've just done a bit of cleanup.

Moved the hander page to the correct URL:
https://developer.mozilla.org/en-US/docs/Web/API/Window/onappinstalled

Updated the event page:
https://developer.mozilla.org/en-US/docs/Web/Events/appinstalled

Updated the entry in the Window index listing:
https://developer.mozilla.org/en-US/docs/Web/API/Window#Event_handlers

Added an entry for the event to the events reference:
https://developer.mozilla.org/en-US/docs/Web/Events

I also added a note to the Fx 52 release notes:
https://developer.mozilla.org/en-US/Firefox/Releases/52#DOM_HTML_DOM

Let me know if that's OK. Thanks!