Benjamin Smedberg Assignee
	Description • 8 years ago

In release 52 we've disabled all plugins except Flash. For ESR 52 we want to leave these other plugins on, so we need to flip this pref on the ESR-specific branch. I'm filing this separately so that it can have good tracking flags for that change.

plugin.load_flash_only needs to be false.

	Benjamin Smedberg Assignee
	Comment 1 • 8 years ago

There is not an ESR52 tracking flag yet, so to keep this on relman radar I'm going to mark it for 52.

	Xidorn Quan [:xidorn] UTC+11
	Comment 2 • 8 years ago

If you are going to turn off load_flash_only, we would need to backout the patch in bug 846566 as well. Could you do that at the same time?

	Benjamin Smedberg Assignee
	Comment 3 • 8 years ago

I would suggest backing out 846566 until 53. I really don't want to compound risk for ESR52.

	Julien Cristau [:jcristau]
	Comment 4 • 8 years ago

Marking this as blocking for 52 so it doesn't get missed.

	Astley Chen (inactive)
	Comment 5 • 7 years ago

Gerry, when will we have status-firefox-esr52 and tracking-firefox-esr52 flag ? With that we can correct the tracking here and leave FF52 as it was.

	Julien Cristau [:jcristau]
	Comment 6 • 7 years ago

Moving tracking to new esr52 flags.

	Julien Cristau [:jcristau]
	Comment 7 • 7 years ago

Can we have a patch made and nominated for the esr52 branch some time soon?

	Chris Peterson [:cpeterson]
	Comment 8 • 7 years ago

Benjamin, can you please post a patch to set the "plugin.load_flash_only" pref on ESR52 or suggest someone else we can ask?

	Benjamin Smedberg Assignee
	Comment 10 • 7 years ago

This is a patch against beta, because I presume there isn't a separate ESR branch yet.

We've already done QA testing that this pref works, but I think we should do a release QA pass on candidate ESR builds to make sure:

1) Java and silverlight show up in the addons manager
2) The browser uses them when appropriate
3) The "some plugins may be missing" notice is not present in the addon manager. It *will* be present in about:plugins, but we've decided that's ok.

	Chris Peterson [:cpeterson]
	Comment 11 • 7 years ago

An ESR52 branch now exists. It is being kept in sync with Beta 52 commits, but is not running CI tests.

https://hg.mozilla.org/releases/mozilla-esr52/

	Jim Mathies [:jimm]
	Comment 12 • 7 years ago
mozreview-review

Comment on attachment 8837677 [details]
Bug 1308761 - Re-enable non-Flash plugins for ESR52,

https://reviewboard.mozilla.org/r/112736/#review114640

	Benjamin Smedberg Assignee
	Comment 13 • 7 years ago

What is supposed to happen next with this bug? Do we wait until RC to branch ESR from the mainline release?

	Ryan VanderMeulen [:RyanVM]
	Comment 14 • 7 years ago

The ESR52 branch is already alive. Go ahead and request approval.

	Julien Cristau [:jcristau]
	Comment 15 • 7 years ago

Comment on attachment 8837677 [details]
Bug 1308761 - Re-enable non-Flash plugins for ESR52,

thanks Benjamin.  re-enable non-flash plugins in the esr52 branch.

	Sylvestre Ledru [:Sylvestre]
	Comment 16 • 7 years ago

Andrei, once it landed and the build is over (    http://archive.mozilla.org/pub/firefox/tinderbox-builds/ )
could you verify this?
Thanks

	Ryan VanderMeulen [:RyanVM]
	Comment 17 • 7 years ago
bugherder uplift

https://hg.mozilla.org/releases/mozilla-esr52/rev/62ca938529e9

	Andrei Vaida [:avaida]
	Comment 18 • 7 years ago

Verified fixed on 52.0.0esr-build4 using: Windows 7 x64, Windows 10 x64, Ubuntu 16.04 x64 and macOS 10.12.3. Non-Flash plug-ins can be enabled on 52esr and they work as intended.

	Sylvestre Ledru [:Sylvestre]
	Comment 19 • 7 years ago

Merci beaucoup! Have a great week end!