Astley Chen (inactive) Assignee
	Description • 8 years ago

mask-type prop support for SVG <mask> element was enabled since 2012. It seems that the corresponding preference control is no longer needed now.

	Astley Chen (inactive) Assignee
	Comment 2 • 8 years ago

TRYing: https://treeherder.mozilla.org/#/jobs?repo=try&revision=dbd428e614ea

	Cameron McCormack (:heycam)
	Comment 3 • 8 years ago
mozreview-review

Comment on attachment 8798481 [details]
Bug 1308239 : Remove CSS mask-type pref layout.css.masking.enabled.

https://reviewboard.mozilla.org/r/83964/#review82998

Thanks, this pref has been enabled by default since 2014, so is overdue for removal.

::: layout/style/test/property_database.js
(Diff revision 1)
> -if (IsCSSPropertyPrefEnabled("layout.css.masking.enabled")) {
> -  gCSSProperties["mask-type"] = {
> +gCSSProperties["mask-type"] = {
> -    domProp: "maskType",
> +  domProp: "maskType",
> -    inherited: false,
> +  inherited: false,
> -    type: CSS_TYPE_LONGHAND,
> +  type: CSS_TYPE_LONGHAND,
> -    initial_values: [ "luminance" ],
> +  initial_values: [ "luminance" ],
> -    other_values: [ "alpha" ],
> +  other_values: [ "alpha" ],
> -    invalid_values: []
> +  invalid_values: []
> -  };
> +};
> -}

Please move this definition up to the main statement that assigns to gCSSProperties.

	Astley Chen (inactive) Assignee
	Comment 5 • 8 years ago
mozreview-review-reply

Comment on attachment 8798481 [details]
Bug 1308239 : Remove CSS mask-type pref layout.css.masking.enabled.

https://reviewboard.mozilla.org/r/83964/#review82998

> Please move this definition up to the main statement that assigns to gCSSProperties.

Updated, thanks for pointing it out. :)

	Astley Chen (inactive) Assignee
	Comment 6 • 8 years ago

Need an update on MDN page: https://developer.mozilla.org/en-US/docs/Web/CSS/mask-type

	Pulsebot
	Comment 7 • 8 years ago

Pushed by cbook@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/c44ee9cb3ba8
Remove CSS mask-type pref layout.css.masking.enabled. r=heycam

	Tim Nguyen :ntim
	Comment 8 • 8 years ago

(In reply to Astley Chen [:astley] (UTC+8) from comment #6)
> Need an update on MDN page:
> https://developer.mozilla.org/en-US/docs/Web/CSS/mask-type

Updated.

	Phil Ringnalda (:philor)
	Comment 9 • 8 years ago
bugherder

https://hg.mozilla.org/mozilla-central/rev/c44ee9cb3ba8