Rob Thijssen [:grenade (EET/UTC+0300)] Assignee
	Description • 8 years ago

Some tests fail because the task user does not have sufficient access rights on the worker instance.

We need to be able to specify the task users groups in either the worker configuration or the task definition (preferred, i think). I will mark failing tests which fall into this category as dependent on this bug.

	Pete Moore [:pmoore][:pete]
	Comment 1 • 8 years ago

I'll be working on this today.

	Pete Moore [:pmoore][:pete]
	Comment 2 • 8 years ago

I think this should do it. It was hard to write unit tests, as they don't run as Administrator - I might change that in future for testing things like this...

I'll do some local testing for now. It is a pretty simple feature, so shouldn't require too much testing.

	Rob Thijssen [:grenade (EET/UTC+0300)] Assignee
	Comment 3 • 8 years ago

Comment on attachment 8798013 [details] [review]
Github Pull Request for generic-worker

lgtm

	[github robot]
	Comment 4 • 8 years ago

Commits pushed to master at https://github.com/taskcluster/generic-worker

https://github.com/taskcluster/generic-worker/commit/9f3bea57343a551fc599a1aecc905837e9006cd9
Bug 1306988 - add feature "OS Groups" to allow tasks to specify extra OS groups that their task user should be made a member of

https://github.com/taskcluster/generic-worker/commit/8e6cbf67730fd41e414d3dcf92f637c4e006c45d
Merge pull request #25 from taskcluster/bug1306988

Bug 1306988 - add feature "OS Groups"

	Pete Moore [:pmoore][:pete]
	Comment 5 • 8 years ago

New release published: https://github.com/taskcluster/generic-worker/releases/tag/v6.0.0

Rob, can you build new AMI(s) from this?

	Pete Moore [:pmoore][:pete]
	Comment 6 • 8 years ago

This is now possible via the "osGroups" feature of generic worker.

See https://docs.taskcluster.net/manual/execution/workers/generic-worker