Markus Stange [:mstange] Assignee
	Description • 8 years ago

This will be useful for bug 658467, and the patch is really simple.

	u459114
	Comment 2 • 8 years ago
mozreview-review

Comment on attachment 8794546 [details]
Bug 1305259 - Use PushGroupAndCopyBackground for the masked group so that we can have subpixel AA inside the mask / clip-path.

https://reviewboard.mozilla.org/r/80964/#review79592

LGTM
(Maybe it's a good idea to run through Talos cart)

	Bas Schouten (:bas.schouten)
	Comment 3 • 8 years ago

(In reply to Markus Stange [:mstange] from comment #0)
> Created attachment 8794545 [details]
> testcase
> 
> This will be useful for bug 658467, and the patch is really simple.

This indeed involved a significant performance hit. Be sure to quantify that.

	Bas Schouten (:bas.schouten)
	Comment 4 • 8 years ago
mozreview-review

Comment on attachment 8794546 [details]
Bug 1305259 - Use PushGroupAndCopyBackground for the masked group so that we can have subpixel AA inside the mask / clip-path.

https://reviewboard.mozilla.org/r/80964/#review79616

	Markus Stange [:mstange] Assignee
	Comment 6 • 8 years ago

Uh, not sure why mozreview decided to re-request review. Anyway, I've added a check so that we only do this if there's actually text over transparent background inside the mask / clip-path, so that we don't pay the cost when it's not necessary.

	Bas Schouten (:bas.schouten)
	Comment 7 • 8 years ago
mozreview-review

Comment on attachment 8796776 [details]
Bug 1305259 - Use PushGroupAndCopyBackground for the masked group so that we can have subpixel AA inside the mask / clip-path.

https://reviewboard.mozilla.org/r/82516/#review81168

	u459114
	Comment 8 • 8 years ago
mozreview-review

Comment on attachment 8796776 [details]
Bug 1305259 - Use PushGroupAndCopyBackground for the masked group so that we can have subpixel AA inside the mask / clip-path.

https://reviewboard.mozilla.org/r/82516/#review81332

	Pulsebot
	Comment 9 • 8 years ago

Pushed by mstange@themasta.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/265f9ccf4fff
Use PushGroupAndCopyBackground for the masked group so that we can have subpixel AA inside the mask / clip-path. r=cjku, r=Bas

	Carsten Book [:Tomcat]
	Comment 10 • 8 years ago
bugherder

https://hg.mozilla.org/mozilla-central/rev/265f9ccf4fff