Mark Banner (:standard8) Assignee
	Description • 8 years ago

Currently I'm working on an example github repository for add-ons that Mozilla develops for test pilot & system add-ons. I'm also working towards better testing facilities for Activity Stream.

As part of that, having Windows workers for testing would be very useful, as that is where most of our users are and gives us reasonable coverage alongside Linux.

As part of this, we need node/npm installed on the windows workers so we can use the install and build facilities within the github repos.

	Pete Moore [:pmoore][:pete]
	Comment 1 • 8 years ago

This will mean looking at e.g. http://blog.teamtreehouse.com/install-node-js-npm-windows to see the steps, and then patching https://github.com/taskcluster/generic-worker/blob/master/worker_types/win2012r2/userdata

	Mark Banner (:standard8) Assignee
	Comment 2 • 8 years ago

I think this should do it...

	[github robot]
	Comment 3 • 8 years ago

Commits pushed to master at https://github.com/taskcluster/generic-worker

https://github.com/taskcluster/generic-worker/commit/030a57c2f90bed4908a0ba8792f8c24a747f7683
Bug 1305048 - Add node 6.6.0 to win2012r2.

https://github.com/taskcluster/generic-worker/commit/c503b02b1f3589bd16351bccff83368b35a8d3b5
Merge pull request #23 from Standard8/bug-1305048-node

Bug 1305048 - Add node 6.6.0 to win2012r2.

	Pete Moore [:pmoore][:pete]
	Comment 4 • 8 years ago

Comment on attachment 8794225 [details] [review]
Link to Github pull-request: https://github.com/taskcluster/generic-worker/pull/23

Looks great, many thanks! :-)

	Pete Moore [:pmoore][:pete]
	Comment 5 • 8 years ago

The new AMIs are currently being created...

us-east-1: ami-1be69d0c
us-west-1: ami-d3327cb3
us-west-2: ami-93419df3

The win2012r2 worker type should automatically get updated when the AMI creation is completed, so should be available shortly for testing (assuming no win2012r2 are still lurking around with an older AMI).

	Pete Moore [:pmoore][:pete]
	Comment 6 • 8 years ago

Keep your eye on https://tools.taskcluster.net/task-inspector/#JLKoTBOOQoeeurFD2aUaJw/0 - it is the original task Mark created that requires npm/node. I've recreated it, and currently a new worker is spinning up in response...

	Pete Moore [:pmoore][:pete]
	Comment 7 • 8 years ago

OK, it looks like that PATH wasn't updated as hoped, new task fixed that:

https://tools.taskcluster.net/task-inspector/#SCAnreSdRSulsHqG1NHQ4g/0

I'll update the worker type to set the PATH correctly so it isn't needed as an extra task step.

	Pete Moore [:pmoore][:pete]
	Comment 8 • 8 years ago

OK that fixed that.

However, looks like npm expects to be run from a bash context, rather than from a command prompt:

https://tools.taskcluster.net/task-inspector/#c-5SqdpwTaSUg8yWzoN04w/0

Mark - please see the adjusted task definition, with multiple commands. It is effectively the same as the command1 && comand2 && command3 && .... commandN construction you previously had (any command failure will cause the task to terminate) but is a little easier to read at a glance.

https://queue.taskcluster.net/v1/task/c-5SqdpwTaSUg8yWzoN04w

I'm going to mark this is as resolved, as we now have npm/node on the workers. Please reopen if you disagree.

Note, you can run commands under msys bash using e.g. C:\mozilla-build\msys\bin\bash.exe - however, I'm not sure the windows version of npm will play nicely with msys - you might need an msys version of npm for that. Alternatively maybe code can be adapted to work under a native windows node installation?

	Pete Moore [:pmoore][:pete]
	Comment 9 • 6 years ago

Released in https://github.com/taskcluster/generic-worker/releases/tag/v5.4.0