Closed
Bug 1290636
Opened 8 years ago
Closed 8 years ago
Expose iterator stuff on NodeList and DOMTokenList
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla50
Tracking | Status | |
---|---|---|
firefox50 | --- | fixed |
People
(Reporter: bzbarsky, Assigned: bzbarsky)
References
Details
(Keywords: dev-doc-complete)
Attachments
(2 files, 1 obsolete file)
2.48 KB,
patch
|
qdot
:
review+
|
Details | Diff | Splinter Review |
6.06 KB,
patch
|
qdot
:
review+
|
Details | Diff | Splinter Review |
The DOM spec has these. Chrome is shipping at least on NodeList (as in, it's in Chrome release), which suggests it's web-compatible.
Assignee | ||
Comment 1•8 years ago
|
||
There were two issues: 1) The keys/entries/values/forEach properties were being added no matater what the value of the 'unforgeable' boolean was. So we ended up spitting out unforgeable versions of those, and this confused some Xray cases. 2) The number of args listed for forEach was wrong, which hit assertions in the JS engine because the same self-hosted function was being instantiated with different numbers of args from different places.
Attachment #8776223 -
Flags: review?(kyle)
Assignee | ||
Comment 2•8 years ago
|
||
There were two issues: 1) The keys/entries/values/forEach properties were being added no matater what the value of the 'unforgeable' boolean was. So we ended up spitting out unforgeable versions of those, and this confused some Xray cases. 2) The number of args listed for forEach was wrong, which hit assertions in the JS engine because the same self-hosted function was being instantiated with different numbers of args from different places.
Attachment #8776228 -
Flags: review?(kyle)
Assignee | ||
Updated•8 years ago
|
Attachment #8776223 -
Attachment is obsolete: true
Attachment #8776223 -
Flags: review?(kyle)
Assignee | ||
Comment 3•8 years ago
|
||
Attachment #8776229 -
Flags: review?(kyle)
Updated•8 years ago
|
Attachment #8776228 -
Flags: review?(kyle) → review+
Updated•8 years ago
|
Attachment #8776229 -
Flags: review?(kyle) → review+
Pushed by bzbarsky@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/6b62785dbfe3 Fix some bugs in the way single-type (value) iterators are hooked up in the Web IDL bindings. r=qdot https://hg.mozilla.org/integration/mozilla-inbound/rev/49efb446f5b0 Expose iterator stuff on NodeList and DOMStringList. r=qdot
Comment 6•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/6b62785dbfe3 https://hg.mozilla.org/mozilla-central/rev/49efb446f5b0
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
Updated•8 years ago
|
Keywords: dev-doc-needed
Comment 7•8 years ago
|
||
Note for documentation team: see specifications: https://dom.spec.whatwg.org/#interface-nodelist and https://dom.spec.whatwg.org/#interface-domtokenlist; also, this is already shipping in Chrome stable. No information on Safari or Edge implementation plans at this time.
Comment 8•8 years ago
|
||
Updated: https://developer.mozilla.org/en-US/Firefox/Releases/50 https://developer.mozilla.org/en-US/docs/Web/API/NodeList https://developer.mozilla.org/en-US/docs/Web/API/DOMTokenList Created: https://developer.mozilla.org/en-US/docs/Web/API/NodeList/forEach https://developer.mozilla.org/en-US/docs/Web/API/NodeList/entries https://developer.mozilla.org/en-US/docs/Web/API/NodeList/keys https://developer.mozilla.org/en-US/docs/Web/API/NodeList/values https://developer.mozilla.org/en-US/docs/Web/API/DOMTokenList/forEach https://developer.mozilla.org/en-US/docs/Web/API/DOMTokenList/entries https://developer.mozilla.org/en-US/docs/Web/API/DOMTokenList/keys https://developer.mozilla.org/en-US/docs/Web/API/DOMTokenList/values
Keywords: dev-doc-needed → dev-doc-complete
Updated•5 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•