Closed
Bug 1289049
Opened 9 years ago
Closed 8 years ago
Add animation support for shape-outside
Categories
(Core :: DOM: Animation, defect, P3)
Core
DOM: Animation
Tracking
()
RESOLVED
FIXED
mozilla57
People
(Reporter: TYLin, Assigned: TYLin)
References
(Blocks 2 open bugs)
Details
(Keywords: dev-doc-complete)
Attachments
(4 files)
Bug 1288626 will add the shape-outside support to the style system without considering animation. Let's complete the animation support here.
Updated•9 years ago
|
Priority: -- → P3
Updated•8 years ago
|
Keywords: dev-doc-needed
Assignee | ||
Comment 1•8 years ago
|
||
Per spec shape-outside [1] and clip-path [2] spec, both properties are animatable on <basic-shape> values, and we already support animation for clip-path on Gecko.
To make shape-outisde animatable on Gecko, I think we'll need to make [3] eStyleAnimType_Custom, and refactor functions deal with StyleShapeSource in layout/style/StyleAnimationValue.cpp to support both clip-path and shape-outside.
Boris Chiou (:boris) should know more animation part than I do.
[1] https://drafts.csswg.org/css-shapes/#propdef-shape-outside
[2] https://drafts.fxtf.org/css-masking-1/#the-clip-path
[3] http://searchfox.org/mozilla-central/rev/3291398f10dcbe192fb52e74974b172616c018aa/layout/style/nsCSSPropList.h#3745
Updated•8 years ago
|
Assignee: nobody → tlin
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Assignee | ||
Comment 6•8 years ago
|
||
Comment 7•8 years ago
|
||
mozreview-review |
Comment on attachment 8910138 [details]
Bug 1289049 Part 4 - Make <basic-shape> animatable for shape-outside for gecko style system.
https://reviewboard.mozilla.org/r/181630/#review186966
Attachment #8910138 -
Flags: review?(boris.chiou) → review+
Comment 8•8 years ago
|
||
mozreview-review |
Comment on attachment 8910137 [details]
Bug 1289049 Part 3 - Add CSS_PROPERTY_STORES_CALC flag to "shape-outside" property.
https://reviewboard.mozilla.org/r/181628/#review186968
Attachment #8910137 -
Flags: review?(boris.chiou) → review+
Comment 9•8 years ago
|
||
mozreview-review |
Comment on attachment 8910135 [details]
Bug 1289049 Part 1 - Use shape source instead of clip path in naming.
https://reviewboard.mozilla.org/r/181624/#review186988
Attachment #8910135 -
Flags: review?(boris.chiou) → review+
Comment 10•8 years ago
|
||
mozreview-review |
Comment on attachment 8910136 [details]
Bug 1289049 Part 2 - Extract a helper function ExtractComputedValueFromShapeSource().
https://reviewboard.mozilla.org/r/181626/#review186994
Attachment #8910136 -
Flags: review?(boris.chiou) → review+
Comment 11•8 years ago
|
||
Pushed by tlin@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/1d5f95ad941e
Part 1 - Use shape source instead of clip path in naming. r=boris
https://hg.mozilla.org/integration/autoland/rev/132a940e3e5f
Part 2 - Extract a helper function ExtractComputedValueFromShapeSource(). r=boris
https://hg.mozilla.org/integration/autoland/rev/92bb93a96a44
Part 3 - Add CSS_PROPERTY_STORES_CALC flag to "shape-outside" property. r=boris
https://hg.mozilla.org/integration/autoland/rev/f599f522b02e
Part 4 - Make <basic-shape> animatable for shape-outside for gecko style system. r=boris
Comment 12•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/1d5f95ad941e
https://hg.mozilla.org/mozilla-central/rev/132a940e3e5f
https://hg.mozilla.org/mozilla-central/rev/92bb93a96a44
https://hg.mozilla.org/mozilla-central/rev/f599f522b02e
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox57:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
Comment 13•8 years ago
|
||
I've documented this by adding a note to the shape-outside browser compat table and experimental features page:
https://developer.mozilla.org/en-US/docs/Web/CSS/shape-outside#Browser_compatibility
https://developer.mozilla.org/en-US/Firefox/Experimental_features#CSS
I've not mentioned it yet in the rel notes because it is still preffed off by default.
Keywords: dev-doc-needed → dev-doc-complete
You need to log in
before you can comment on or make changes to this bug.
Description
•