Dylan Hardison [:dylan] (he/him) Assignee
	Description • 8 years ago

Under heavy usage, the bug modal edit API will cause web workers to run out of memory every 60 seconds. It's a good idea to fix the memory leak now.

	Dylan Hardison [:dylan] (he/him) Assignee
	Comment 1 • 8 years ago

This should fix much of the memory leaks. Running under mod_perl, you can run 'ab' against the bug modal API to test. -c 4 -n 1000 should result in frequent SizeLimit messages in the error log. With this patch applied, memory usage (for that API) should be nearly constant.

	Dylan Hardison [:dylan] (he/him) Assignee
	Comment 2 • 8 years ago

This removes the majority of memory leaks from BMO.

	Dylan Hardison [:dylan] (he/him) Assignee
	Comment 3 • 8 years ago

wrong patch. This one should work.

	David Lawrence [:dkl]
	Comment 5 • 8 years ago

Comment on attachment 8765972 [details] [diff] [review]
1282606_4.patch

Review of attachment 8765972 [details] [diff] [review]:
-----------------------------------------------------------------

mac-thor?

Fix comments on commit. r=dkl

::: Bugzilla/Comment.pm
@@ +241,5 @@
>  sub bug {
>      my $self = shift;
>      require Bugzilla::Bug;
> +    my $bug = $self->{bug} ||= new Bugzilla::Bug($self->bug_id);
> +    weaken($self->{bug});

need to import 'weaken' at the beginning of Comment.pm

::: extensions/TrackingFlags/Extension.pm
@@ +555,5 @@
> +sub request_cleanup {
> +    foreach my $flag (@FLAG_CACHE) {
> +        my $bug_flag = delete $flag->{bug_flag};
> +        if ($bug_flag) {
> +            my $bug = delete $bug_flag->{bug};

nit: no need to assign to $bug, just do delete $bug_flag->{bug};

	Dylan Hardison [:dylan] (he/him) Assignee
	Comment 6 • 8 years ago

To git@github.com:mozilla-bteam/bmo.git
   3bf65ba..9a15297  master -> master