Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout) Reporter
	Description • 8 years ago

https://treeherder.mozilla.org/logviewer.html#?job_id=30278790&repo=mozilla-inbound

18:09:23     INFO -  8949 INFO TEST-PASS | devtools/client/inspector/markup/test/browser_markup_tag_edit_04.js | #pseudo::before is selected after deletion -
18:09:23     INFO -  8950 INFO Check that the node was really removed
18:09:23     INFO -  8951 INFO TEST-PASS | devtools/client/inspector/markup/test/browser_markup_tag_edit_04.js | The node can't be found in the page anymore -
18:09:23     INFO -  8952 INFO Undo the deletion to restore the original markup
18:09:23     INFO -  8953 INFO TEST-PASS | devtools/client/inspector/markup/test/browser_markup_tag_edit_04.js | The last change in the markup-view can be undone -
18:09:24     INFO -  8954 INFO TEST-PASS | devtools/client/inspector/markup/test/browser_markup_tag_edit_04.js | The node is back -
18:09:24     INFO -  8955 INFO Leaving test bound
18:09:25     INFO -  8956 INFO Removing tab.
18:09:25     INFO -  8957 INFO Waiting for event: 'TabClose' on [object XULElement].
18:09:25     INFO -  8958 INFO Got event: 'TabClose' on [object XULElement].
18:09:25     INFO -  8959 INFO Tab removed and finished closing
18:09:25     INFO -  TEST-INFO | started process screentopng
18:09:27     INFO -  TEST-INFO | screentopng: exit 0
18:09:27     INFO -  8960 INFO checking window state
18:09:27     INFO -  8961 INFO TEST-UNEXPECTED-FAIL | devtools/client/inspector/markup/test/browser_markup_tag_edit_04.js | This test exceeded the timeout threshold. It should be rewritten or split up. If that's not possible, use requestLongerTimeout(N), but only as a last resort. -

	Julian Descottes [:jdescottes] Assignee
	Comment 1 • 8 years ago

Inspector bug triage, filter on CLIMBING SHOES.

	Julian Descottes [:jdescottes] Assignee
	Comment 4 • 8 years ago

Looking at successful runs of the same test on Linux platforms, the test always takes around 40 seconds, which is close to the default timeout of 45 seconds. Will split it in 2 tests.

	Julian Descottes [:jdescottes] Assignee
	Comment 5 • 8 years ago

For the record, the test time initially increased with Bug 1107658, where I added 2 new test cases in the same test.

	Julian Descottes [:jdescottes] Assignee
	Comment 6 • 8 years ago

Review commit: https://reviewboard.mozilla.org/r/62342/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/62342/

	Julian Descottes [:jdescottes] Assignee
	Comment 8 • 8 years ago

Comment on attachment 8767945 [details]
Bug 1280729 - split intermittent test browser_markup_tag_edit_04.js;

No activity for a week, forwarding the review.

	Brian Grinstead [:bgrins]
	Comment 9 • 8 years ago

Comment on attachment 8767945 [details]
Bug 1280729 - split intermittent test browser_markup_tag_edit_04.js;

https://reviewboard.mozilla.org/r/62342/#review60718

::: devtools/client/inspector/markup/test/browser_markup_tag_edit_04-backspace.js:61
(Diff revision 1)
> +  for (let data of TEST_DATA) {
> +    yield checkDeleteAndSelection(inspector, data);
> +  }
> +});
> +
> +function* checkDeleteAndSelection(inspector, {selector, focusedSelector, pseudo}) {

Is this function basically copy/pasted?  I'd suggest to move it to head.js and keep `key` in the destructuring or as an arg to the function

	Julian Descottes [:jdescottes] Assignee
	Comment 10 • 8 years ago

Comment on attachment 8767945 [details]
Bug 1280729 - split intermittent test browser_markup_tag_edit_04.js;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/62342/diff/1-2/

	Brian Grinstead [:bgrins]
	Comment 11 • 8 years ago

Comment on attachment 8767945 [details]
Bug 1280729 - split intermittent test browser_markup_tag_edit_04.js;

https://reviewboard.mozilla.org/r/62342/#review60748

	Julian Descottes [:jdescottes] Assignee
	Comment 12 • 8 years ago

Try is green : https://treeherder.mozilla.org/#/jobs?repo=try&revision=b1f900ebbd76 
Landing

	Pulsebot
	Comment 13 • 8 years ago

Pushed by jdescottes@mozilla.com:
https://hg.mozilla.org/integration/fx-team/rev/a03a6fd88c3d
split intermittent test browser_markup_tag_edit_04.js;r=bgrins

	Carsten Book [:Tomcat]
	Comment 14 • 8 years ago
bugherder

https://hg.mozilla.org/mozilla-central/rev/a03a6fd88c3d

	Ryan VanderMeulen [:RyanVM]
	Comment 16 • 8 years ago
bugherder uplift

https://hg.mozilla.org/releases/mozilla-aurora/rev/73ce55a62039