John Dai[:jdai] Assignee
	Description • 8 years ago

According to session 4.13.4[1], we need to implement CustomElementsRegistry get function.


[1] https://html.spec.whatwg.org/multipage/scripting.html#dom-customelementsregistry-get

	Andrew Overholt [:overholt]
	Comment 1 • 8 years ago

(I'm marking all the Custom Elements bugs as "backlog" but that's just to indicate they're not something we're fixing urgently and no comment on priority or anything.)

	Edgar Chen [:edgar]
	Comment 4 • 8 years ago

Comment on attachment 8789736 [details] [diff] [review]
Bug 1275838 - Implement CustomElementsRegistry get function.

Review of attachment 8789736 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM.

	John Dai[:jdai] Assignee
	Comment 5 • 8 years ago

Try result:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=a6c22adf7c6163b8be7f9574f1b0d015efe20816&filter-tier=1

	Carsten Book [:Tomcat]
	Comment 6 • 8 years ago

need dom peer review: remote: WebIDL file dom/webidl/CustomElementsRegistry.webidl altered in changeset f0c053165318 without DOM peer review

	John Dai[:jdai] Assignee
	Comment 7 • 8 years ago

Comment on attachment 8791113 [details] [diff] [review]
Bug 1275838 - Implement CustomElementsRegistry get function. r=wchen

I forgot to ask DOM peer review. 
Hi Olli, 
Could you help to review my patch? Thank you.

	Olli Pettay [:smaug][bugs@pettay.fi]
	Comment 8 • 8 years ago

Comment on attachment 8791113 [details] [diff] [review]
Bug 1275838 - Implement CustomElementsRegistry get function. r=wchen

r+ for the .webidl

	Pulsebot
	Comment 10 • 8 years ago

Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/a2d8c1189368
Implement CustomElementsRegistry get function. r=smaug, r=wchen

	Carsten Book [:Tomcat]
	Comment 11 • 8 years ago
bugherder

https://hg.mozilla.org/mozilla-central/rev/a2d8c1189368

	Chris Mills [:cmills]
	Comment 12 • 7 years ago

I've made sure this method is documented:
https://developer.mozilla.org/en-US/docs/Web/API/CustomElementRegistry/get

I've also added a note to the Fx52 release notes: 
https://developer.mozilla.org/en-US/Firefox/Releases/52#DOM_HTML_DOM

Let me know if this is OK. Thanks!