Shawn Huang [:shawnjohnjr][:shuang] (as a happy gecko contributor) Assignee
	Description • 8 years ago

Add permission 'persistent-storage'

	Andrew Overholt [:overholt]
	Comment 1 • 8 years ago

I'm guessing you're planning on working on this soon, Shawn, so I'm marking as 'fixlater'. Feel free to correct that.

	Shawn Huang [:shawnjohnjr][:shuang] (as a happy gecko contributor) Assignee
	Comment 2 • 8 years ago

Based on https://w3c.github.io/permissions/#persistent-storage.
"persistent-storage" permission allows an origin to make its site storage unit contain a persistent box. "persistent-storage" is a boolean feature.

	Shawn Huang [:shawnjohnjr][:shuang] (as a happy gecko contributor) Assignee
	Comment 5 • 8 years ago

Comment on attachment 8815157 [details] [diff] [review]
Bug 1270038 - Add permission 'persistent-storage' for StorageManager

Hi baku,
This patch adds permission-registry PermissionName 'persistent-storage' to support querying permission 'persistent-storage'.


[1] https://w3c.github.io/permissions/#permission-registry
[2] https://storage.spec.whatwg.org/#dom-permissionname-persistent-storage

	Shawn Huang [:shawnjohnjr][:shuang] (as a happy gecko contributor) Assignee
	Comment 6 • 8 years ago

Oh. I just found test_permissions_api.html also copied to browser/components/originattributes/test/mochitest/test_permissions_api.html. I should also modify this test case.

	Shawn Huang [:shawnjohnjr][:shuang] (as a happy gecko contributor) Assignee
	Comment 8 • 8 years ago

Comment on attachment 8815169 [details] [diff] [review]
Bug 1270038 - Add permission 'persistent-storage' for StorageManager

Hi baku,
This patch adds permission-registry PermissionName 'persistent-storage' to support querying permission 'persistent-storage'.


[1] https://w3c.github.io/permissions/#permission-registry
[2] https://storage.spec.whatwg.org/#dom-permissionname-persistent-storage

I also tested this patch with patches on bug 1286717. It looks good.

	Shawn Huang [:shawnjohnjr][:shuang] (as a happy gecko contributor) Assignee
	Comment 9 • 7 years ago

https://treeherder.mozilla.org/#/jobs?repo=try&revision=27f6a4bde78c6514da767f9850998016f6c81e9a

	Pulsebot
	Comment 10 • 7 years ago

Pushed by shuang@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/3e4c27ba3875
Add permission 'persistent-storage' for StorageManager, r=baku

	Carsten Book [:Tomcat]
	Comment 11 • 7 years ago
bugherder

https://hg.mozilla.org/mozilla-central/rev/3e4c27ba3875

	Chris Mills [:cmills]
	Comment 12 • 7 years ago

I've documented this.

I've added details of the new permission name and updated browser support info on relevant pages:
https://developer.mozilla.org/en-US/docs/Web/API/Permissions_API
https://developer.mozilla.org/en-US/docs/Web/API/Permissions
https://developer.mozilla.org/en-US/docs/Web/API/Permissions/revoke
https://developer.mozilla.org/en-US/docs/Web/API/Permissions/query

I've also added a note to the Fx53 release notes:
https://developer.mozilla.org/en-US/Firefox/Releases/53#DOM_HTML_DOM

Let me know if this looks OK - thanks!