Closed
Bug 1266268
Opened 8 years ago
Closed 8 years ago
[css-grid] Implement <percentage> for grid gap properties
Categories
(Core :: Layout, defect, P4)
Core
Layout
Tracking
()
RESOLVED
FIXED
mozilla49
People
(Reporter: MatsPalmgren_bugz, Assigned: MatsPalmgren_bugz)
References
(Blocks 1 open bug)
Details
(Keywords: dev-doc-complete)
Attachments
(2 files)
|
12.29 KB,
patch
|
dholbert
:
review+
|
Details | Diff | Splinter Review |
|
17.21 KB,
patch
|
Details | Diff | Splinter Review |
https://lists.w3.org/Archives/Public/www-style/2016Apr/0351.html - RESOLVED: Add <percentage> to grid-gap - RESOLVED: Mark the above as at-risk
|
Assignee | |
Comment 1•8 years ago
|
||
|
|
Assignee | |
Comment 2•8 years ago
|
||
|
||
Comment 3•8 years ago
|
||
Comment on attachment 8754876 [details] [diff] [review] fix Review of attachment 8754876 [details] [diff] [review]: ----------------------------------------------------------------- Looks good, thanks!
Attachment #8754876 -
Flags: review?(dholbert) → review+
|
|
||
Updated•8 years ago
|
Keywords: dev-doc-needed
https://hg.mozilla.org/integration/mozilla-inbound/rev/2d60e772249d https://hg.mozilla.org/integration/mozilla-inbound/rev/1e79a41fdac1
|
|
Assignee | |
Updated•8 years ago
|
Flags: in-testsuite+
|
||
Comment 5•8 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/2d60e772249d https://hg.mozilla.org/mozilla-central/rev/1e79a41fdac1
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox49:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla49
The percentage of grid-row-gap is based on what size to calculate? In CSS 2.1, margin-top/bottom is based on containing block width.
Update: https://developer.mozilla.org/en-US/docs/Web/CSS/grid-gap https://developer.mozilla.org/en-US/Firefox/Releases/49#CSS
|
||
Comment 8•8 years ago
|
||
I've updated too https://developer.mozilla.org/en-US/docs/Web/CSS/grid-row-gap https://developer.mozilla.org/en-US/docs/Web/CSS/grid-column-gap (Percentage is relative to the dimension of the element)
Keywords: dev-doc-needed → dev-doc-complete
|
||
Updated•7 months ago
|
You need to log in
before you can comment on or make changes to this bug.
Description
•