Closed
Bug 1265586
Opened 8 years ago
Closed 7 years ago
web-platform-tests reftest runner converts screenshots to base64 even for passing tests
Categories
(Testing :: web-platform-tests, defect)
Testing
web-platform-tests
Tracking
(firefox48 affected)
RESOLVED
FIXED
Tracking | Status | |
---|---|---|
firefox48 | --- | affected |
People
(Reporter: dbaron, Unassigned)
References
(Blocks 1 open bug)
Details
If I run: ./mach web-platform-tests 2dcontext/drawing-images-to-the-canvas/drawimage_canvas_4.html which is a test that passes, I see base64 encoded versions of screenshot images in the log. In the primary reftest harness, we don't do base64 conversion (which is quite expensive) unless the image comparison fails. This saved a substantial amount of load on our continuous integration infrastructure and made the tests run substantially faster. We instead use DOMWindowUtils.compareCanvases
Comment 1•8 years ago
|
||
This isn't something that we can do right now because wptrunner uses marionette to drive the tests. If marionette gave a primitive to allow taking a screenshot and storing it in the browser, and another primitive for comparing stored screenshots, we could replicate this optimisation.
Comment 2•7 years ago
|
||
fixed by #1363428, no?
Updated•7 years ago
|
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•