Marcos Caceres [:marcosc] Assignee
	Description • 8 years ago

Implement the window.oninstall event handler attribute.

	Marcos Caceres [:marcosc] Assignee
	Comment 1 • 8 years ago

Baku, does this look ok? The event is supposed to be fired by the user agent when a "progressive web app" is successfully installed somewhere (e.g., user's homescreen on a mobile device).

	Andrea Marchesini [:baku]
	Comment 2 • 8 years ago

Comment on attachment 8753751 [details] [diff] [review]
0001-Bug-1265279-Web-Manifest-Implement-window.oninstall.patch

Review of attachment 8753751 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/ipc/manifestMessages.js
@@ +69,5 @@
> +    const ev = new Event("install");
> +    const response = makeMsgResponse(id);
> +    if (!content || content.top !== content) {
> +      let msg = "Can only dispatch install event on top-level browsing contexts.";
> +      response.result = serializeError(new Error(msg));

should we localize this error message?

	Marcos Caceres [:marcosc] Assignee
	Comment 3 • 8 years ago

(In reply to Andrea Marchesini (:baku) from comment #2)
> Comment on attachment 8753751 [details] [diff] [review]
> 0001-Bug-1265279-Web-Manifest-Implement-window.oninstall.patch
> 
> Review of attachment 8753751 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: dom/ipc/manifestMessages.js
> @@ +69,5 @@
> > +    const ev = new Event("install");
> > +    const response = makeMsgResponse(id);
> > +    if (!content || content.top !== content) {
> > +      let msg = "Can only dispatch install event on top-level browsing contexts.";
> > +      response.result = serializeError(new Error(msg));
> 
> should we localize this error message?

Right now, the error would only be used internally so I don't think it's necessary.

	Marcos Caceres [:marcosc] Assignee
	Comment 5 • 8 years ago

https://treeherder.mozilla.org/#/jobs?repo=try&revision=406558c68631

	Marcos Caceres [:marcosc] Assignee
	Comment 6 • 8 years ago

https://treeherder.mozilla.org/#/jobs?repo=try&revision=fed18f455f37

	Marcos Caceres [:marcosc] Assignee
	Comment 7 • 8 years ago

... no idea why it worked for me locally... mochitests are gross.

	Marcos Caceres [:marcosc] Assignee
	Comment 8 • 8 years ago

https://treeherder.mozilla.org/#/jobs?repo=try&revision=2ff61cd36266

	Pulsebot
	Comment 10 • 8 years ago

https://hg.mozilla.org/integration/mozilla-inbound/rev/9143e6d98cdf

	Carsten Book [:Tomcat]
	Comment 11 • 8 years ago
bugherder

https://hg.mozilla.org/mozilla-central/rev/9143e6d98cdf

	Jean-Yves Perrier [:teoli]
	Comment 12 • 8 years ago

Added an entry in:
https://developer.mozilla.org/en-US/docs/Web/API/Window#Event_handlers

Created:
https://developer.mozilla.org/en-US/docs/Web/API/Window/oninstall
https://developer.mozilla.org/en-US/docs/Web/Events/install

Updated:
https://developer.mozilla.org/en-US/Firefox/Releases/49#Others